432287 - add buttons and icons for zoom in/out to toolbar customization palette

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

While we don't have dedicated UI for zoom, we might want to add buttons for it to the toolbar palette.

(requested by Walt Mossberg)

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: screenshot of zoom slider in Content Preferences extension

The content preferences extension includes a customizable toolbar widget for setting the zoom.  It's a slider, which I think is the wrong approach, but it might be useful as a template for how to implement such a widget.

Content Preferences extension:

https://addons.mozilla.org/en-US/firefox/addon/4066

Blog post with thoughts about (among other things) the zoom widget:

http://www.melez.com/mykzilla/2008/08/content-preferences-now-with-toolbar.html

Also see the Glazoom extension's implementation:

https://addons.mozilla.org/en-US/firefox/addon/6489

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Mike, did you have a particular vision for how toolbarbuttons for zoom might look/work?

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.

Secondary interface since these buttons won't be displayed by default, but otherwise they would be primary interface.

Comment 4

[Danial Horton]

I'd like to see built in default zoom, like the one IE has based on the screens DPI, but thats another subject.... i do agree that the browser should have settable buttons for zoom by default however.

Comment 5

[Dão Gottwald [:dao]]

Attachment: patch

tryserver build: http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-3b62044775ef/
I think the icons look better on OS X than on Windows, but I expect them to be placeholders anyway.

Comment 6

[u88484]

(In reply to comment #5)
> Created attachment 470774 [details] [diff] [review]
> patch
> 
> tryserver build:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/[e-mail]-3b62044775ef/
> I think the icons look better on OS X than on Windows, but I expect them to be
> placeholders anyway.

Works fine on Windows 7.  Seems a little slower to change zoom level than when pressing ctrl++ or ctrl+- though.  Shouldn't the labels be camel case instead of sentence case, "Zoom In" instead of the current "Zoom in".

Probably for a follow-up bug but there should be a way to reset back to 100%

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 470774 [details] [diff] [review]
patch

Definitely good to have this as an option.  We might want to consider some alternate and more complex interfaces in the future though, like a menu that contains multiple levels and a radio control, or a panel that pops up a slider control (similar to the work being done in bug 592147)

Comment 8

[Asaf Romano (gone)]

I'll review this today.

Comment 9

[Dão Gottwald [:dao]]

Mano, ping?
I know this isn't high priority, but would be nice to get it in before the string freeze.

Comment 10

[Dão Gottwald [:dao]]

(In reply to comment #6)
> Shouldn't the labels be camel case instead
> of sentence case, "Zoom In" instead of the current "Zoom in".

These aren't labels but tooltips.

Comment 11

[Dão Gottwald [:dao]]

Attachment: strings

Comment 12

[Asaf Romano (gone)]

Comment on attachment 470774 [details] [diff] [review]
patch


diff --git a/browser/locales/en-US/chrome/browser/browser.dtd b/browser/locales/en-US/chrome/browser/browser.dtd
--- a/browser/locales/en-US/chrome/browser/browser.dtd
+++ b/browser/locales/en-US/chrome/browser/browser.dtd

+<!ENTITY zoomOutButton.tooltip          "Zoom out">
+<!ENTITY zoomInButton.tooltip           "Zoom in">

Elsewhere we use Zoom In and Zoom Out (maybe we should just use the menuitems labels).

r=mano otherwise.

Comment 13

[Dão Gottwald [:dao]]

(In reply to comment #12)
> +<!ENTITY zoomOutButton.tooltip          "Zoom out">
> +<!ENTITY zoomInButton.tooltip           "Zoom in">
> 
> Elsewhere we use Zoom In and Zoom Out (maybe we should just use the menuitems
> labels).

I do use the menuitem labels :)
The above strings are tooltips.

Comment 14

[Asaf Romano (gone)]

Yes.  You could use them for the tooltips as well iff they're equal: I still don't understand the capitalization change.

Comment 15

[Dão Gottwald [:dao]]

It's consistent with "Go back one page", "Reload current page", "Display your bookmarks" etc.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 470774 [details] [diff] [review]
patch

a=beltzner

Comment 17

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/bf3472021948

Comment 18

[u88484]

Verified fixed using Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100911 Firefox/4.0b6pre