Closed Bug 432287 Opened 12 years ago Closed 10 years ago

add buttons and icons for zoom in/out to toolbar customization palette

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 4.0b7

People

(Reporter: beltzner, Assigned: dao)

References

(Blocks 3 open bugs)

Details

(Keywords: polish, ue, Whiteboard: [strings] [polish-hard] [polish-visual] [polish-p2])

Attachments

(1 file, 2 obsolete files)

While we don't have dedicated UI for zoom, we might want to add buttons for it to the toolbar palette.

(requested by Walt Mossberg)
The content preferences extension includes a customizable toolbar widget for setting the zoom.  It's a slider, which I think is the wrong approach, but it might be useful as a template for how to implement such a widget.

Content Preferences extension:

https://addons.mozilla.org/en-US/firefox/addon/4066

Blog post with thoughts about (among other things) the zoom widget:

http://www.melez.com/mykzilla/2008/08/content-preferences-now-with-toolbar.html

Also see the Glazoom extension's implementation:

https://addons.mozilla.org/en-US/firefox/addon/6489
Whiteboard: [polish-hard] [polish-visual]
Mike, did you have a particular vision for how toolbarbuttons for zoom might look/work?
Assignee: nobody → dao
Whiteboard: [polish-hard] [polish-visual] → [polish-hard] [polish-visual][icons-3.2]
Whiteboard: [polish-hard] [polish-visual][icons-3.2] → [polish-hard] [polish-visual][icon-3.2]
This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.

Secondary interface since these buttons won't be displayed by default, but otherwise they would be primary interface.
Whiteboard: [polish-hard] [polish-visual][icon-3.2] → [polish-hard] [polish-visual][icon-namoroka][polish-p2]
I'd like to see built in default zoom, like the one IE has based on the screens DPI, but thats another subject.... i do agree that the browser should have settable buttons for zoom by default however.
Attached patch patchSplinter Review
tryserver build: http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/dgottwald@mozilla.com-3b62044775ef/
I think the icons look better on OS X than on Windows, but I expect them to be placeholders anyway.
Attachment #345322 - Attachment is obsolete: true
Attachment #470774 - Flags: ui-review?(faaborg)
Attachment #470774 - Flags: review?(mano)
Status: NEW → ASSIGNED
Whiteboard: [polish-hard] [polish-visual][icon-namoroka][polish-p2] → [polish-hard] [polish-visual] [polish-p2]
(In reply to comment #5)
> Created attachment 470774 [details] [diff] [review]
> patch
> 
> tryserver build:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/dgottwald@mozilla.com-3b62044775ef/
> I think the icons look better on OS X than on Windows, but I expect them to be
> placeholders anyway.

Works fine on Windows 7.  Seems a little slower to change zoom level than when pressing ctrl++ or ctrl+- though.  Shouldn't the labels be camel case instead of sentence case, "Zoom In" instead of the current "Zoom in".

Probably for a follow-up bug but there should be a way to reset back to 100%
Comment on attachment 470774 [details] [diff] [review]
patch

Definitely good to have this as an option.  We might want to consider some alternate and more complex interfaces in the future though, like a menu that contains multiple levels and a radio control, or a panel that pops up a slider control (similar to the work being done in bug 592147)
Attachment #470774 - Flags: ui-review?(faaborg) → ui-review+
Mano, ping?
I know this isn't high priority, but would be nice to get it in before the string freeze.
(In reply to comment #6)
> Shouldn't the labels be camel case instead
> of sentence case, "Zoom In" instead of the current "Zoom in".

These aren't labels but tooltips.
Attached patch strings (obsolete) — Splinter Review
Attachment #472146 - Flags: approval2.0?
Whiteboard: [polish-hard] [polish-visual] [polish-p2] → [strings] [polish-hard] [polish-visual] [polish-p2]
Comment on attachment 470774 [details] [diff] [review]
patch


diff --git a/browser/locales/en-US/chrome/browser/browser.dtd b/browser/locales/en-US/chrome/browser/browser.dtd
--- a/browser/locales/en-US/chrome/browser/browser.dtd
+++ b/browser/locales/en-US/chrome/browser/browser.dtd

+<!ENTITY zoomOutButton.tooltip          "Zoom out">
+<!ENTITY zoomInButton.tooltip           "Zoom in">

Elsewhere we use Zoom In and Zoom Out (maybe we should just use the menuitems labels).

r=mano otherwise.
Attachment #470774 - Flags: review?(mano) → review+
(In reply to comment #12)
> +<!ENTITY zoomOutButton.tooltip          "Zoom out">
> +<!ENTITY zoomInButton.tooltip           "Zoom in">
> 
> Elsewhere we use Zoom In and Zoom Out (maybe we should just use the menuitems
> labels).

I do use the menuitem labels :)
The above strings are tooltips.
Attachment #470774 - Flags: approval2.0?
Attachment #472146 - Attachment is obsolete: true
Attachment #472146 - Flags: approval2.0?
Yes.  You could use them for the tooltips as well iff they're equal: I still don't understand the capitalization change.
It's consistent with "Go back one page", "Reload current page", "Display your bookmarks" etc.
Comment on attachment 470774 [details] [diff] [review]
patch

a=beltzner
Attachment #470774 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/bf3472021948
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Blocks: 595618
Blocks: 595619
Blocks: 595621
Verified fixed using Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b6pre) Gecko/20100911 Firefox/4.0b6pre
Status: RESOLVED → VERIFIED
Blocks: 595623
No longer blocks: 595623
Blocks: 595624
Blocks: 595686
You need to log in before you can comment on or make changes to this bug.