Closed Bug 432293 Opened 12 years ago Closed 12 years ago

Non-browser apps shouldn't need to build xpfe/components/history/public

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
xpfe/components/history/public provides nsIBrowserHistory.idl; there is only one instance it is used outside of browser/ suite/ .../places or .../history directories, and that instance is actually only required for non MOZ_XUL_APPs:

http://mxr.mozilla.org/seamonkey/search?string=nsIBrowserHistory

We should therefore drop building it for TB, SB and Composer (is Composer still active?). This will mean several apps building one less directory in xpfe, as well as making it clearer which interfaces are really used/available.

If any of these want to pick up history or places later, then it'll make that easier as well.
Attachment #319443 - Flags: superreview?(neil)
Attachment #319443 - Flags: review?(ted.mielczarek)
Attachment #319443 - Flags: superreview?(neil) → superreview+
Attachment #319443 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 319443 [details] [diff] [review]
The fix

Given that the decision for Thunderbird & co hasn't been made yet wrt 1.9/mozilla-central, requesting approval for check in on 1.9.

The build-config change to the Makefile.in will only affect Thunderbird, Sunbird and stand-alone Camino.

The include change will "affect" more, but it is only required in that file in non-MOZ_XUL_APP places, hence it won't affect FF its just effectively removing a redundant include.
Attachment #319443 - Flags: approval1.9?
Patch checked into mozilla-central so marking as fixed. Still want this for 1.9.0 given no decisions have been made yet.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 319443 [details] [diff] [review]
The fix

Moving nomination to new 1.9.0.1. Drivers please see comment 1 for original approval request.
Attachment #319443 - Flags: approval1.9? → approval1.9.0.1?
Attachment #319443 - Flags: approval1.9.0.1? → approval1.9.0.2?
Comment on attachment 319443 [details] [diff] [review]
The fix

No point in doing this one now TB is almost into hg.
Attachment #319443 - Flags: approval1.9.0.2?
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.