Closed
Bug 432405
Opened 17 years ago
Closed 17 years ago
key testing should use native event routing
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file, 1 obsolete file)
|
2.04 KB,
patch
|
roc
:
review+
roc
:
superreview+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
When we synthesize a native key event on Mac OS X we should send it via NSApplication's sendEvent: method so that the application does normal event routing (NSApp -> key window -> first responder) instead of keyDown: or keyUp: for whatever widget synthesized the event. This lets us test focus and takes into account the platform's quirks re: keyDown: vs. performKeyEquivalent:.
Like so... I get one test failure with this patch on Mac OS X 10.5, which is down from 2 test failures without this patch.
The change to the test makes sure that the key events are flowing to something that has the listener installed.
Attachment #319527 -
Attachment is obsolete: true
Attachment #319610 -
Flags: superreview?(roc)
Attachment #319610 -
Flags: superreview?(roc) → superreview+
Attachment #319610 -
Flags: review+
Attachment #319610 -
Flags: approval1.9?
|
||
Comment 3•17 years ago
|
||
Comment on attachment 319610 [details] [diff] [review]
fix v1.1
a1.9+=damons
Attachment #319610 -
Flags: approval1.9? → approval1.9+
landed on trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•