Closed Bug 432418 Opened 16 years ago Closed 16 years ago

Can't talk in DCC Chat

Categories

(Other Applications :: ChatZilla, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glasshound, Assigned: bugzilla-mozilla-20000923)

References

Details

(Keywords: regression, Whiteboard: [cz-0.9.82.1])

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: Chatzilla 0.9.82[Firefox 2.0.0.14/2008040413]

With the upgrade to 0.9.82, my DCC Chat sessions no longer work with command line entries such as "dir", "cd" or commands specifically noted in the users MOTD instructions. 

[ERROR]	Internal error dispatching command “say”.
[ERROR]	TypeError: o.server has no properties @ 
                      <chrome://chatzilla/content/commands.js> 2177

Reproducible: Always

Steps to Reproduce:
1. Connect to server (enigma.hugi.org)
2. Join channel. /ctcp <username> <sharename>
3. Accept DCC Chat. Type command in command line of DCC Chat session window
Actual Results:  
Below are the results. This occurs with every DCC session (more than one user) I've connected with.

[ERROR]	Internal error dispatching command “say”.
[ERROR]	TypeError: o.server has no properties @ 
                      <chrome://chatzilla/content/commands.js> 2177

Expected Results:  
The "cd" and "dir" commands should work as they did before the update, allowing directory traversing and listing.

I went on to the #chatzilla channel for advice. They had the same results. They weren't used to DCC Chat session commands, thinking that a "/" would be required for what I always use. They suggested I file a bug report with details.

This behaviour only began immediately after updating Chatzilla last night. I can no longer request files via Chatzilla/DCC Chat at this point.
Ah, yes, well found. Calling them commands is what is confusing, as they're not commands to ChatZilla (because they don't start with "/"), it's just normal chat text (which just happens to be treated as a command by the other user). Looks like we totally broke that with 0.9.82, oops.

Looks easy enough to fix.
Severity: normal → major
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Summary: DCC Chat commands fail → Can't talk in DCC Chat
Version: unspecified → Trunk
Assignee: rginda → silver
Status: NEW → ASSIGNED
Attachment #319552 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 319552 [details] [diff] [review]
Only split lines when we have a server

r=me
Attachment #319552 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: regression
Checked in --> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.82.1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: