432482 - Can't read userlist in 0.9.82

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Robert Ginda]

Attachment: screenshot

[INFO] ChatZilla 0.9.82 [Firefox 2.0.0.14/2008040413]

Userlist is white-on white, except away users who are grey on white.  Also the splitter between the userlist and message area is about twice as wide as it should be.

I'm also not much a fan of the new icons, but I suppose they might look better on a dark background.

Comment 1

[Robert Ginda]

Attachment: screenshot, partially filled userlist

notice that the background is black where there are no usernames

Comment 2

[James Ross]

Attachment: Override colours more agressively on non-selected rows

The additional JS code is because Gecko doesn't provide any way to check for a property NOT being set, so this sets something to check for.

CSS squashes any colours set for the row, cell and text by the theme when the row is not selected - this should deal with the immediate Mac issue (it works on two black/alternate-row-colours themes on Windows).

Comment 3

[Robert Ginda]

Attachment: screenshot of silver's changes

Comment 4

[:Gijs (he/him)]

(In reply to comment #3)
> Created an attachment (id=319632) [details]
> screenshot of silver's changes
> 

Don't we want the area of the userlist rather than just the rows and so on to be black as well? The white lines in the screenshot look jarring to me, but perhaps that's just me... Would it be useful to stick another !important, this time after the relevant background-color and color lines? for the list rather than its rows/cells ?

Comment 5

[James Ross]

We've not been able to work out why the white lines are there; the additions in this patch back the background for rows/cells the same as the overall area (the problem was the Mac theme sets the background colour for each row but not the text colour).

Not sure an !important on the treechildren stuff would be useful, it's not been needed in any existing case where as the others are needed.

Comment 6

[James Ross]

Attachment: Set the property on rows this time

This time it actually works - I was setting the 'unselected' property on the *cell* and thus the -moz-tree-row(unselected) never matched, which left the border lying around. This patch sets it on the *row*, which is inherited by the cell as well.

Comment 7

[:Gijs (he/him)]

Comment on attachment 319675 [details] [diff] [review]
Set the property on rows this time

r=me

Comment 8

[James Ross]

Checked in --> FIXED.

Comment 10

[:Gijs (he/him)]

So can anyone else reproduce this, apart from the person who filed the bug I just duped? It works for me on Win XP. I suspect the XUL Cache...

Comment 11

[:Gijs (he/him)]

All/All per the fact that the duped bug is on Windows Vista...

Comment 12

[James Ross]

I wouldn't have duped the bugs if I were you, especially before knowing what theme they're using...

Comment 13

[Paul]

Just checked and it's theme related.

I use BlackJapan and Aquatint Black Gloss as my main themes.  Use Dark Motif (different from this bug) and you have black text (Default for these themes) on a black background.

So is this a css problem with dark motif not explicitly declaring Userlist text as white?

Comment 14

[James Ross]

If you're using the dark motif that ships with ChatZilla (View menu, Color Scheme - make sure the dark option has a tick next to it), there is definitely no problem with the motif.

In 0.9.82, it declared the colours in a normal manner (setting both foreground and background, as you can see in the patch in bug 410962) which worked for all but a few cases (unfortunately including the default theme on Mac).

In this bug, we improved it to override themes entirely when using the dark motif for 0.9.82.1, which deals with both the default Mac theme and the few downloadable themes that also had issues.

If you're using a dark motif that is NOT shipped with ChatZilla, then it is entirely possible the motif (or the theme) needs changes to work correctly.

Comment 15

[Paul]

Attachment: Using BlackJapan with Default motif

It doesn't override the BlackJapan theme.

Comment 16

[Paul]

Attachment: BlackJapan and Dark Motif

This is the dark motif supplied with Chatzilla while I'm using the BlackJapan theme.

Comment 17

[James Ross]

Yeah, I thought I'd tested this one but apparently not - the theme is doing some really broken things which need even more work to override. I've worked it out here, so we can fix it.

Comment 18

[James Ross]

Attachment: Set 'unselected' property on cells as well because Gecko is crap

This fixes the BlackJapan theme here, and highlights multiple failings in Gecko's tree support (like not inheriting properties, directly or indirectly, having multiple property entry points but not having as many as there are pseudo-elements, etc.).

Comment 19

[:Gijs (he/him)]

Comment on attachment 320795 [details] [diff] [review]
Set 'unselected' property on cells as well because Gecko is crap

r=me

We should cache all these stupid atoms at some point, I suppose (be damned, XPCOM boundaries). But there's another bug filed for that.

Comment 20

[:Gijs (he/him)]

Comment on attachment 320795 [details] [diff] [review]
Set 'unselected' property on cells as well because Gecko is crap

Bugzilla should have mind reading. 'Nuff said.

Comment 21

[James Ross]

Checked in --> FIXED (again).

Comment 22

[Jeff Walden [:Waldo]]

Attachment: OS X 10.4 screenshot

So I don't think this is working correctly -- see the screenshot.  OS X 10.4, using the faces motif.

Comment 23

[:Gijs (he/him)]

(In reply to comment #22)
> Created an attachment (id=323655) [details]
> OS X 10.4 screenshot
> 
> So I don't think this is working correctly -- see the screenshot.  OS X 10.4,
> using the faces motif.
> 

What version of ChatZilla is this? Have you tried a nightly?

Comment 24

[:Gijs (he/him)]

(In reply to comment #22)
> Created an attachment (id=323655) [details]
> OS X 10.4 screenshot
> 
> So I don't think this is working correctly -- see the screenshot.  OS X 10.4,
> using the faces motif.
> 

Actually, the faces motif from where? I don't believe we ever fully adapted it. Does the normal dark motif work correctly?

Comment 25

[Jeff Walden [:Waldo]]

(In reply to comment #23)
> What version of ChatZilla is this? Have you tried a nightly?

It was 0.9.80ish.  #chatzilla suggested using a newer version, which fixed the problem.

(In reply to comment #24)
> Actually, the faces motif from where? I don't believe we ever fully adapted it.
> Does the normal dark motif work correctly?

Just the one directly recommended on the faces.pl page:

http://chatzilla.hacksrus.com/motifs/output-dark-faces.css

CSS imports say it was using the normal dark motif as a base, and that dark motif was what had been updated to work with the newer version of Chatzilla but not with older versions.