Closed Bug 432598 Opened 14 years ago Closed 14 years ago

Don't show EULA for debug builds

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3

People

(Reporter: mozbugs, Assigned: mozbugs)

Details

Attachments

(1 file, 1 obsolete file)

Don't show EULA for debug builds, take 2
748 bytes, patch
Gavin
: review+
mconnor
: approval1.9+
Details | Diff | Splinter Review
Attached patch Don't show EULA for debug builds (obsolete) — — Splinter Review 
Since when you're doing browser development you're more likely to be using fresh profiles, the EULA dialog just adds an annoyance. Patch attached bypasses this for debug builds.

The EULA is already turned off for Windows and Mac, even though when you've self built you haven't used an installer, so this doesn't actually introduce any new policy imho.
Attachment #319762 - Flags: review?(gavin.sharp)
Status: NEW → ASSIGNED
Assignee: nobody → manish
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
I'd just add:

#ifdef DEBUG
pref("browser.EULA.override", true);
#endif

to avoid having to change the pref every time we update the EULA version. Otherwise this is probably OK.
Attachment #319762 - Attachment is obsolete: true
Attachment #319965 - Flags: review?(gavin.sharp)
Attachment #319762 - Flags: review?(gavin.sharp)
Attachment #319965 - Flags: review?(gavin.sharp) → review+
Comment on attachment 319965 [details] [diff] [review]
Don't show EULA for debug builds, take 2

No-risk debug only fix to avoid the annoying EULA dialog for debug build first-runs.
Attachment #319965 - Flags: approval1.9?
Attachment #319965 - Flags: approval1.9? → approval1.9+
mozilla/browser/app/profile/firefox.js 	1.336
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.