432611 - given-name and family-name should be plural properties

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Fix + testcase

I'm not sure when this changed, or maybe I was wrong from the beginning, but given-name and family-name should be plural properties.

Without this change people would start coding expecting it to be a string, but it will become an array when this gets fixed later.

I know it seems strange to request blocking on this, but this is an underlying API change that needs to be made.

Note the test change looks extensive, but it is not. It's just adding the array index to the existing testcases.

Comment 1

[Mike Schroepfer]

Moving to blocking since it affects the public API.  Given the extensive tests I'm happy to take this now once reviewed..

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Kaply, please land ASAP.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Landed this at beltzner's request.

mozilla/toolkit/components/microformats/src/Microformats.js 	1.27
mozilla/toolkit/components/microformats/tests/test_Microformats_hCard.html 	1.8

Comment 4

[Mike Kaply [:mkaply]]

Thanks for landing. On a plane for way too long yesterday.