given-name and family-name should be plural properties

RESOLVED FIXED in mozilla1.9

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Trunk
mozilla1.9
Points:
---
Bug Flags:
blocking1.9 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

Created attachment 319768 [details] [diff] [review]
Fix + testcase

I'm not sure when this changed, or maybe I was wrong from the beginning, but given-name and family-name should be plural properties.

Without this change people would start coding expecting it to be a string, but it will become an array when this gets fixed later.

I know it seems strange to request blocking on this, but this is an underlying API change that needs to be made.

Note the test change looks extensive, but it is not. It's just adding the array index to the existing testcases.
Flags: blocking1.9?
Attachment #319768 - Flags: review?(sayrer)

Comment 1

11 years ago
Moving to blocking since it affects the public API.  Given the extensive tests I'm happy to take this now once reviewed..
Flags: blocking1.9? → blocking1.9+

Updated

11 years ago
Attachment #319768 - Flags: review?(sayrer) → review+
Attachment #319768 - Flags: approval1.9?

Updated

11 years ago
Attachment #319768 - Flags: approval1.9? → approval1.9+
Kaply, please land ASAP.
Whiteboard: [has patch][has review][has approval]
Landed this at beltzner's request.

mozilla/toolkit/components/microformats/src/Microformats.js 	1.27
mozilla/toolkit/components/microformats/tests/test_Microformats_hCard.html 	1.8
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review][has approval]
Target Milestone: --- → mozilla1.9
Thanks for landing. On a plane for way too long yesterday.
You need to log in before you can comment on or make changes to this bug.