Closed
Bug 432717
Opened 18 years ago
Closed 18 years ago
t/008filter.t incorrectly reports [% foo.${bar} = baz %] as unsafe
Categories
(Bugzilla :: Testing Suite, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.2
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
Attachments
(1 file)
|
641 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
It doesn't like ${bar} but likes $bar. Both are valid and safe.
Attachment #319877 -
Flags: review?(mkanat)
|
||
Comment 1•18 years ago
|
||
Comment on attachment 319877 [details] [diff] [review]
patch, v1
Yes, this is pretty obviously correct. Although somebody could do something *really* crazy inside of ${}, that's something we'd catch in review (and that no sane person would do anyway).
Attachment #319877 -
Flags: review?(mkanat) → review+
|
|
||
Updated•18 years ago
|
Flags: approval+
Target Milestone: --- → Bugzilla 3.2
|
|
Assignee | |
Comment 2•18 years ago
|
||
Checking in t/008filter.t;
/cvsroot/mozilla/webtools/bugzilla/t/008filter.t,v <-- 008filter.t
new revision: 1.28; previous revision: 1.27
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•