432769 - Dehydra/Treehydra: should not cast location_t to int on a mac

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Vlad Sukhoy]

In dehydra.c:

dehydra_defineProperty (this, obj, "_source_location", INT_TO_JSVAL(loc));

breaks mac because loc is larger than int there. Can't we just store bytes of it in a JS string or something?

Comment 1

[David Mandelin [:dmandelin]]

What exactly is the failure mode? If the values actually fit in ints, then it could be made to work by adding another cast or something.

Comment 2

[Vlad Sukhoy]

it doesn't fit in an int. because it is as follows:

struct  GTY(()) location_s
{
  /* The name of the source file involved.  */
  const char *file;

  /* The line-location in the source file.  */
  int line;
};

typedef struct location_s expanded_location;
typedef struct location_s location_t;
typedef location_t *source_locus;

so it's an int and a pointer.

Comment 3

[David Mandelin [:dmandelin]]

OK, given this I think you can just leave off _source_location on the Mac, and then just modify Diagnostic() to set up a new location_s structure if needed for %H.

Comment 4

[Benjamin Smedberg]

Is this specific to mac or to gcc 4.2? Probably ought to file these bugs as "shouldn't do X on GCC 4.2" if that's actually the difference.

Comment 5

[Vlad Sukhoy]

Not sure how gcc 4.2 is configured on linux by default. This is actually specific to apple's gcc42 config not using  USE_MAPPED_LOCATION define during gcc build which turns on mapped locations (and columns in them). I am not sure why apple does it this way with their gcc.

Comment 6

[Vlad Sukhoy]

Attachment: fix

Comment 7

[David Mandelin [:dmandelin]]

Comment on attachment 320075 [details] [diff] [review]
fix

Perfect.

Comment 8

[Vlad Sukhoy]

Pushed.