Closed Bug 432800 Opened 12 years ago Closed 11 years ago

make elf-dynstr-gc silent on success

Categories

(Firefox Build System :: General, defect, trivial)

All
Linux
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: ynvich, Assigned: ynvich)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008040315 Firefox/3.0b5
Build Identifier: 20080508 trunk

Optimized linux builds collect unreferenced strings from binaries. If the binary contains no such strings, a debug message is still printed:

Couldn't GC any strings, exiting.

Reproducible: Always

Steps to Reproduce:
1. Build with enable-optimized on linux

Actual Results:  
Debug message is printed for each binary:

Couldn't GC any strings, exiting.

Expected Results:  
Debug message is not printed.

Patch follows.
The patch removes polluting line. If the line is important, it may be wrapped in "#ifdef DEBUG".
Attachment #319963 - Flags: review?(benjamin)
Attachment #319963 - Flags: review?(benjamin) → review+
Comment on attachment 319963 [details] [diff] [review]
proposed fix
[Checkin: Comment 3]

This patch doesn't affect build products, only build system output. It is .999999 safe to land.
Attachment #319963 - Flags: approval1.9?
Keywords: checkin-needed
Comment on attachment 319963 [details] [diff] [review]
proposed fix
[Checkin: Comment 3]


http://hg.mozilla.org/mozilla-central/rev/409ff9f2be41
Attachment #319963 - Attachment description: proposed fix → proposed fix [Checkin: Comment 3]
Assignee: nobody → ynvich
Status: UNCONFIRMED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Comment on attachment 319963 [details] [diff] [review]
proposed fix
[Checkin: Comment 3]

Removing "obsolete" 'approval1.9=?':
ask for current flag(s), as needed.
Attachment #319963 - Flags: approval1.9?
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.