432895 - talos try unable to pull builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

The Try Server Talos master can no longer pull builds -- it doesn't appear to be able to scrape the filenames correctly. I bet that the upgrade of Apache 2.0 -> Apache 2.2 earlier this week killed it. I won't have time to investigate further until next week.

Comment 1

[alice nodelman [:alice] [:anode]]

Attachment: possible fix

This is currently running on the tryperfmaster and seems to be working.  It does break some of the code that pulls dates out of file names, but that doesn't appear to be called anywhere.

There is a bug where if a build fails we end up picking up and testing the previous workable build.  We need some smarts in there to ignore changes that result in broken/non-existent builds.  But, I believe that this problem has been here for a while so it could be split off into another bug.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 320092 [details] [diff] [review]
possible fix

This looks great. You shouldn't need to worry about it pulling the latest build all the time because it won't build unless TinderboxPoller triggers it. There is a race condition here though, I think. If two builds end really close together you could end up pulling the second one twice and skipping the first one altogether. Both would be labeled as that build, however, so it's less serious than it could be. (That's how I'm reading this code at least, can you confirm that Rob?) If such a condition does exist it's not new though so I'm not worried about it here. We should fix it at some point, of course.

Comment 3

[alice nodelman [:alice] [:anode]]

Checking in perfrunner.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/tryperfmaster/perfrunner.py,v  <--  perfrunner.py
new revision: 1.3; previous revision: 1.2
done