[mozilla-central] Hardcoded autoconf-2.13 in client.mk breaks OS X builds

RESOLVED FIXED

Status

RESOLVED FIXED
11 years ago
9 months ago

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 320087 [details] [diff] [review]
Patch

Hardcoded autoconf-2.13 in client.mk breaks OS X builds.

MacPorts has autoconf named 'autoconf213' for some reason :(
Attachment #320087 - Flags: superreview?(ted.mielczarek)
Attachment #320087 - Flags: review?(joshmoz)

Comment 1

11 years ago
Comment on attachment 320087 [details] [diff] [review]
Patch

Awesome.

To add to the summary, macports is how we recommend people set up their build environment. This removes an unnecessary step in getting a build going.
Attachment #320087 - Flags: review?(joshmoz) → review+
Comment on attachment 320087 [details] [diff] [review]
Patch

r+a=me for checkin to mozilla-central. Let's get this in before it becomes a pain point for people.
Attachment #320087 - Flags: superreview?(ted.mielczarek) → superreview+
See also bug 434075, which is just a more general version of this bug.  Ubuntu Linux has autoconf named "autoconf2.13", which breaks builds on that OS, too.

I'd say that we'd like a more general solution than what this bug's current patch includes.

But I could still see us using the patch posted here as a temporary workaround for Mac users, and then figuring out a more general solution on bug 434075.
Landed this on moz-central.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Blocks: 434075

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.