432911 - [mozilla-central] Hardcoded autoconf-2.13 in client.mk breaks OS X builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch

Hardcoded autoconf-2.13 in client.mk breaks OS X builds.

MacPorts has autoconf named 'autoconf213' for some reason :(

Comment 1

[Josh Aas]

Comment on attachment 320087 [details] [diff] [review]
Patch

Awesome.

To add to the summary, macports is how we recommend people set up their build environment. This removes an unnecessary step in getting a build going.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 320087 [details] [diff] [review]
Patch

r+a=me for checkin to mozilla-central. Let's get this in before it becomes a pain point for people.

Comment 3

[Daniel Holbert [:dholbert]]

See also bug 434075, which is just a more general version of this bug.  Ubuntu Linux has autoconf named "autoconf2.13", which breaks builds on that OS, too.

I'd say that we'd like a more general solution than what this bug's current patch includes.

But I could still see us using the patch posted here as a temporary workaround for Mac users, and then figuring out a more general solution on bug 434075.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Landed this on moz-central.