432925 - dehydra cfg-like functionality for treehydra

Status: RESOLVED INVALID

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[(dormant account)]

Attachment: iterator

Comment 1

[David Mandelin [:dmandelin]]

1. Would you mind renaming some things, for more descriptiveness and to match the existing abstract interpretation stuff:

  iter -> flowState
  structurally_equal -> equal
  duplicate -> copyState
  initial_state -> initState

  preconditions -> seenStates
  guard -> seenStateMap

(actually, I'm a bit unsure about the "seen" part. "visited" or something may be better.)

2. Note that there are sink bbs (i.e. having no successors) other than the exit block. I think they happen with exceptions (and you will see them in any method that does memory allocation). 

You may want to call path_end for those as well. And you probably want to provide an argument that indicates whether it's a normal exit or not. 

Alternatively, you might want to exclude those paths from the traversal entirely--AFAIK they never contain anything interesting. My Python prototype stuff did that. I just looked up and it did it by first finding all the nodes that can reach the exit block, and then traversing only those nodes.

Comment 2

[David Mandelin [:dmandelin]]

Comment on attachment 320096 [details] [diff] [review]
iterator

Cleaning up ancient review requests.