43293 - Mozilla crashes in removeAttributeNS(...) method

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs for DOM, defect, P3)

Description

[Michail Romanov]

Overview Description: 
Mozilla crashes in removeAttributeNS(String namespacURI, String localName)
method of ElementImpl class if any parameter is null.

Steps to Reproduce: 
Run JavaDOM API ElementImpl_removeAttributeNS_String_String_0 testcase. 

Actual Results: 
Mozilla crashes.

Expected Results: 
Mozilla should'n crash in any case.

Build Date & Platform Bug Found: 
06/20/2000 Windows NT 4.0

Additional Information:
Actually Mozilla crashes because return operator is missed after
line 528 in java/dom/jni/org_mozilla_dom_ElementImpl.cpp file:

521 JNIEXPORT void JNICALL Java_org_mozilla_dom_ElementImpl_removeAttributeNS
522   (JNIEnv *env, jobject jthis, jstring jnamespaceURI, jstring jlocalName)
523 {
524   nsIDOMElement* element = (nsIDOMElement*) 
525     env->GetLongField(jthis, JavaDOMGlobals::nodePtrFID);
526   if (!element || !jnamespaceURI || !jlocalName) {
527     JavaDOMGlobals::ThrowException(env,
528       "Element.removeAttributeNS: NULL pointer");
>>>>>>>>
529   }
530 
531   nsString* namespaceURI = JavaDOMGlobals::GetUnicode(env, jnamespaceURI);
532   if (!namespaceURI)
533       return;

Comment 1

[Akhil Arora]

reassigning to the real owner

Comment 2

[leger]

Adding crash keyword

Comment 3

[Denis Sharypov]

missed return statement.
fixed.

Comment 4

[Vladimir Strigun]

Verified with mozilla branch  Netscape_6_1_RELEASE and blackwood 
branch JAVADEV_6_1_20010831 on NT.
Mozilla do not crashed.