433009 - Front Themes page under 'We Recommend' doesn't check version compatibility

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Ryan A. C.]

The page in the URL (clicking themes on the front AMO page) doesn't seem to do a version compatibility check.

I am running Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050906 Minefield/3.0pre and that page is currently offering https://addons.mozilla.org/en-US/firefox/addon/6070 as a theme, with the 'Add to Firefox' button green and working.

The individual add-on page has the "This add-on is for older versions of Firefox" message with the 'Add to Theme' button grayed and unavailable.

Comment 2

[Ryan A. C.]

Reopening on the grounds that bug 415263 did not seem to fix this as shown here: https://preview.addons.mozilla.org/en-US/firefox/browse/type:2
The page is still showing "add to Firefox" regardless of whether the extension is compatible with the users version of Firefox.

Comment 4

[Tony Chung [:tchung]]

More Repro steps are in https://bugzilla.mozilla.org/show_bug.cgi?id=426953#c8.  

Comment 5

[Chris Pollett]

Attachment: patch to fix problem

When placing the featured element unto the themes category landing page the variable used to check compatible apps was not passed causing the problem.

The fix was to pass this variable.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

This fixes Zotero too, right?  https://preview.addons.mozilla.org/en-US/firefox/addon/3504 has a green install button, but when the installTrigger runs, says it's not compatible with Minefield 3.0pre.

Comment 7

[Tony Chung [:tchung]]

nom'ing this for blocking firefox3.   morgamic, can we get this fixed before we ship fx3?

Comment 8

[Chris Pollett]

thanks for the review laura.
Checked into r14504

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> This fixes Zotero too, right? 
> https://preview.addons.mozilla.org/en-US/firefox/addon/3504 has a green install
> button, but when the installTrigger runs, says it's not compatible with
> Minefield 3.0pre.

Scratch that, I had a tricked-out |general.useragent.override| value :-(

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of themes category landing page, production

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of themes category landing page, preview

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

See comment 11; compatibility checking is back and working on preview.

Verified FIXED