433025 - Still using windows icon in Security Exception dialog

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Michael Monreal [:micmon]]

The Security Exception still uses the windows waring icon instead of the gtk stock icon on linux.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Comment 2

[Kai Engert (:KaiE:)]

Comment on attachment 320217 [details] [diff] [review]
patch - v1

I'm ok with this change, if you know it makes sense.
r=kengert

(But I don't know if it's the right thing to do. It would be good to have one more person confirm this is the right thing to do.)

Comment 3

[Reed Loden [:reed]]

Comment on attachment 320217 [details] [diff] [review]
patch - v1

I did the same type of fix in bug 432938, so yeah, it's right.

This fixes another obvious Windows icon to be a GTK stock icon on Linux.

Comment 4

[Kai Engert (:KaiE:)]

ok thanks

Comment 5

[Mike Schroepfer]

Comment on attachment 320217 [details] [diff] [review]
patch - v1

a+ for GTK fix

Comment 6

[Reed Loden [:reed]]

Checking in security/manager/pki/resources/jar.mn;
/cvsroot/mozilla/security/manager/pki/resources/jar.mn,v  <--  jar.mn
new revision: 1.58; previous revision: 1.57
done
Checking in security/manager/pki/resources/content/exceptionDialog.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/exceptionDialog.xul,v  <--  exceptionDialog.xul
new revision: 1.9; previous revision: 1.8
done