Closed Bug 433025 Opened 13 years ago Closed 13 years ago

Still using windows icon in Security Exception dialog

Categories

(Core Graveyard :: Security: UI, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9

People

(Reporter: micmon, Assigned: reed)

Details

Attachments

(1 file)

The Security Exception still uses the windows waring icon instead of the gtk stock icon on linux.
Attached patch patch - v1Splinter Review
Assignee: kengert → reed
Status: NEW → ASSIGNED
Attachment #320217 - Flags: review?(kengert)
Comment on attachment 320217 [details] [diff] [review]
patch - v1

I'm ok with this change, if you know it makes sense.
r=kengert

(But I don't know if it's the right thing to do. It would be good to have one more person confirm this is the right thing to do.)
Attachment #320217 - Flags: review?(kengert) → review+
Comment on attachment 320217 [details] [diff] [review]
patch - v1

I did the same type of fix in bug 432938, so yeah, it's right.

This fixes another obvious Windows icon to be a GTK stock icon on Linux.
Attachment #320217 - Flags: approval1.9?
ok thanks
Comment on attachment 320217 [details] [diff] [review]
patch - v1

a+ for GTK fix
Attachment #320217 - Flags: approval1.9? → approval1.9+
Checking in security/manager/pki/resources/jar.mn;
/cvsroot/mozilla/security/manager/pki/resources/jar.mn,v  <--  jar.mn
new revision: 1.58; previous revision: 1.57
done
Checking in security/manager/pki/resources/content/exceptionDialog.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/exceptionDialog.xul,v  <--  exceptionDialog.xul
new revision: 1.9; previous revision: 1.8
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.