Closed Bug 433083 Opened 12 years ago Closed 11 years ago
Monkey stand-alone shell by default
Split Fred's complaint out into bug 434532.
I thought I had managed that in bug 361268 (just looked at the Makefile.am...)
I'm not totally sure about which variables are the right ones to use, but the try server likes this patch on all three platforms.
Attachment #344947 - Flags: review?(ted.mielczarek)
Comment on attachment 344947 [details] [diff] [review] Bug 433083: Build SpiderMonkey stand-alone shell by default. Can you file a followup on making this less sucky? Either by fixing things so js can link against libjs, or fixing the build system to let us produce a static library alongside the shared library. This is fine for now, though.
Attachment #344947 - Flags: review?(ted.mielczarek) → review+
Sure. This doesn't include line-editing capability.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
This change seems to have busted the Sunbird tinderboxen (http://tinderbox.mozilla.org/Sunbird/), because we host additional calendar scripts in dist/bin/js/, see <http://mxr.mozilla.org/comm-central/source/calendar/base/src/Makefile.in#117>.
Would it be possible to make building the js standalone optional, so we can omit it for sunbird builds? Otherwise we'd run into quite some effort maintaining the packaging/update process, because a lot of calendar files are hosted in dist/bin/js/.
You can file a bug on making the js shell optional, with a configure argument to disable it. You might also just move those files to somewhere else. dist/bin/js seems like a very vague location.
Why not call the js shell |jsshell| like it is for |xpcshell| or make it configurable like suggested in comment #0? Sunbird has used that directory long before.
Because the JS shell has been called 'js' longer than Sunbird's existed :-P. Filing a new bug on making it optional (preferably with a patch!) is still the best way to proceed, though.
The JS shell has been called "js" since before mozilla was open-source. We aren't going to change it now. The only difference is that we're building it as part of the mozilla build process, so that we can run JS tests as part of our regular build system.
Since we might want to use the js shell for testing, too, it's better to fix the clashing directory instead of going with a configure option; filed bug 462393.
Was the actual outcome for what we ship, that Mac Fx, Tb, and SM and Linux Tb (the things that are currently building, and that don't have a packages(-static) file) are now shipping the js shell, and all the other product/platform combinations aren't, what was intended?
You need to log in before you can comment on or make changes to this bug.