433084 - Dehydra/Treehydra/GCC: parameter attributes overridden by function definitions.

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[David Mandelin [:dmandelin]]

From bug 420933 comment 3:

  It appears that parameter annotations in function definitions
  override those in function declarations. I.e., given:

    PRBool Get(..., nsIFoo **aFoo NS_OUTPARAM);

    PRBool Get(..., nsIFoo **aFoo) {
      // code
    }

  At the call site for Get, there will be no attribute.

I have confirmed that GCC does this by reading the source. The key line of code is in cp/decl.c near line 2000:

  DECL_ARGUMENTS (olddecl) = DECL_ARGUMENTS (newdecl)

This code is executed when a definition occurs after a declaration, and it overwrites the argument list entirely, thus clobbering all attributes from the declaration.

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Proposed patch to add to Dehydra GCC patch queue

This does what we need, and allows the analysis to work as needed in bug 431832, and passes all our test cases and builds FF.

We will need to check on this for Mac eventually.

Comment 2

[(dormant account)]

Comment on attachment 320305 [details] [diff] [review]
Proposed patch to add to Dehydra GCC patch queue

Nice and concise, go ahead and add this to the patch queue, i'd put this patch after plugin.diff

Comment 3

[David Mandelin [:dmandelin]]

Pushed.