Closed Bug 433086 Opened 14 years ago Closed 14 years ago

improve nsDOMWindowUtils::Redraw

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

Details

Attachments

(1 file)

redraw() has some major problem, visible under X; one, it was never actually calling the XSync that was there, because the #define is MOZ_ENABLE_GTK2 and not MOZ_WIDGET_GTK2.  Two, calling XSync after each invalidate isn't quite right; usually you want to test a number of calls all at once and then XSync afterwards or you don't get a reasonable impression of performance.

I fixed the first, and I took the opportunity to change how redraw works -- it now has an optional argument that lets you specify the number of sync invalidates to do, and it returns the number of ms the entire cycle took.
Attached patch improve redrawSplinter Review
improvements as mentioned above.
Attachment #320288 - Flags: superreview?(roc)
Attachment #320288 - Flags: review?(roc)
Attachment #320288 - Flags: superreview?(roc)
Attachment #320288 - Flags: superreview+
Attachment #320288 - Flags: review?(roc)
Attachment #320288 - Flags: review+
Blocks: 436061
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.