If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

improve nsDOMWindowUtils::Redraw

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

redraw() has some major problem, visible under X; one, it was never actually calling the XSync that was there, because the #define is MOZ_ENABLE_GTK2 and not MOZ_WIDGET_GTK2.  Two, calling XSync after each invalidate isn't quite right; usually you want to test a number of calls all at once and then XSync afterwards or you don't get a reasonable impression of performance.

I fixed the first, and I took the opportunity to change how redraw works -- it now has an optional argument that lets you specify the number of sync invalidates to do, and it returns the number of ms the entire cycle took.
Created attachment 320288 [details] [diff] [review]
improve redraw

improvements as mentioned above.
Attachment #320288 - Flags: superreview?(roc)
Attachment #320288 - Flags: review?(roc)
Attachment #320288 - Flags: superreview?(roc)
Attachment #320288 - Flags: superreview+
Attachment #320288 - Flags: review?(roc)
Attachment #320288 - Flags: review+

Updated

9 years ago
Blocks: 436061
No longer blocks: 436061
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.