433110 - generated code is not executable and crashes

Status: RESOLVED FIXED

(Tamarin Graveyard :: Tracing Virtual Machine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032620 Firefox/3.0b5
Build Identifier: 

I went to run TT on a simple "hello world" script and it crashed.  This looks like the cause of bug 432683, but I filed a new one since it is more specific (and I'm unable to test on Windows right now).  Nonetheless it will indeed crash DEP since nMarkExecute() is not implemented.  Similarly it'll crash Linux systems that have NX-bit support.

Reproducible: Always

Steps to Reproduce:
Get tamarin-tracing to run a hot path (generated code) on a system with the NX bit being enforced.
Actual Results:  
Segfault

Expected Results:  
Shouldn't segfault

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: proposed fix

I tested that it compiled on Windows but I can't test that it fixes bug 432683 (DEP crashing) with my computer.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 320299 [details] [diff] [review]
proposed fix

pushed