Closed
Bug 433118
Opened 17 years ago
Closed 17 years ago
Treehydra: Backward analysis does not iterate over loops
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dmandelin, Unassigned)
Details
Attachments
(1 file)
|
1.55 KB,
patch
|
taras.mozilla
:
review+
|
Details | Diff | Splinter Review |
I discovered a problem in the forward analysis framework when preparing a demo of the liveness analysis. The result of the problem is that analyses make only a single reverse-postorder pass, instead of iterating over loops to a fixed point. It's not a huge deal for current analyses, but it's definitely wrong, and could theoretically reduce the accuracy of the outparams analysis (the ESP framework is not directly affected, but determination of live variables and return values is).
Patch is attached.
|
Reporter | |
Updated•17 years ago
|
Attachment #320310 -
Flags: review?(tglek)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 320310 [details] [diff] [review]
Proposed patch
From what i can understand, looks reasonable to me
Attachment #320310 -
Flags: review?(tglek) → review+
|
|
Reporter | |
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•