433204 - basic support for using interpreter/tracer as independent library

Status: VERIFIED WONTFIX

(Tamarin Graveyard :: Tracing Virtual Machine, defect)

Description

[Mike Shaver (:shaver emeritus)]

I'm experimenting with generating Forth IL from a source other than the Verifier (namely, from Spidermonkey), and there were a few tweaks I needed to get the basics going (so far).  I attach them here for your review!

(In the future, I would like to refactor the Interpreter interface such that it depended only on GC and Configuration and not need an AvmCore; it appears to be feasible, but will need some different checking for verbose flags and some reparameterization.)

Comment 1

[Mike Shaver (:shaver emeritus)]

Attachment: build tweaks, Interpreter::interpCodeBuffer, fix INTERP_DONE to update state

4 parts to this patch:

- honour CXXFLAGS on Mac
- wrap the rule-inclusion parts of the generated Makefile so that it can be included semi-easily from other consumer code (this wants more work, but works surprisingly well for me!)
- make INTERP_DONE update the InterpState, so that the caller can see the right thing to pop/peek to get the result(s)
- interpCodeBuffer, which just lets you run a buffer of Forth with some optional args

Comment 2

[Mike Shaver (:shaver emeritus)]

(FWIW, with this patch and the child's-play hackery like that found in http://hg.mozilla.org/users/shaver_mozilla.com/js-trace/ we can get the forth interpreter up and tracing in another program, such as a Spidermonkey shell. :) )

Comment 3

[Edwin Smith]

to land, it'd be good to factor interpMethodEnv and use interpCodeBuffer(), just to avoid cut & paste.  The LOCALS_TO_STATE change looks right, i've also got it the patch for bug 433629, whoever pushes first, wins

Comment 4

[Edwin Smith]

LMK if you want help to unbitrot this, or just let it slide.  Ive got the LOCALS_TO_STATE on deck in a different patch.

Comment 5

[Mike Shaver (:shaver emeritus)]

Yeah, no plans for this at present.  I'll close it out as WONTFIX, can reopen if we later decide it's worth the investment.

Comment 6

[Edwin Smith]

fyi the INTERP_DONE fix has been pushed with other changes.