433282 - Template hooks do not work if HTTP_ACCEPT_LANGUAGE doesn't match any language available

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

getLanguages() defined in Bugzilla::Template::Plugin::Hook doesn't fall back to english if none of the available languages matches HTTP_ACCEPT_LANGUAGE despite Bugzilla itself falls back to english for the page itself. This means that template hooks are not processeed. Calling include_languages() rather than getLanguages() ensures we use the same language for hooks and pages.

3.0.4 is probably affected too, but this release doesn't have include_languages() and I don't want to hack it too much to get hooks working.

Comment 1

[Max Kanat-Alexander]

Comment on attachment 320486 [details] [diff] [review]
patch, v1

Yeah, if this works, this is a lot better architecturally anyhow!

Comment 2

[Max Kanat-Alexander]

Comment on attachment 320486 [details] [diff] [review]
patch, v1

Oh, but do you really even need the use_languages argument? Doesn't that actually *default* to Bugzilla->languages? (And if not, why not?)

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> Oh, but do you really even need the use_languages argument? Doesn't that
> actually *default* to Bugzilla->languages? (And if not, why not?)

If we don't pass Bugzilla->languages, include_languages() does its own scan of template/* instead of using the (maybe already cached) list of available languages. IMO, we should file a bug to fix it and force it to use Bugzilla->languages instead. This would be a nice cleanup as the caller wouldn't have to call Bugzilla->languages itself.

Comment 4

[Max Kanat-Alexander]

(In reply to comment #3)
> If we don't pass Bugzilla->languages, include_languages() does its own scan of
> template/* instead of using the (maybe already cached) list of available
> languages. IMO, we should file a bug to fix it and force it to use
> Bugzilla->languages instead. This would be a nice cleanup as the caller
> wouldn't have to call Bugzilla->languages itself.

  Hm...Bugzilla.pm might not be available at the time it's called. But we should have it use _cache and then have Bugzilla.pm use the same cache for Bugzilla->languages or something.

Comment 5

[Frédéric Buclin]

Checking in Bugzilla/Template/Plugin/Hook.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template/Plugin/Hook.pm,v  <--  Hook.pm
new revision: 1.10; previous revision: 1.9
done