433358 - Check for availLeft on startup to prevent Dock overlap

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Stefan [:stefanh]]

If you have the Dock at the left side of your desktop, the left side of the SeaMonkey window will position itself under the Dock upon first launch. We should probably take that into account. JFTR: You can have the Dock at left, right and bottom. Not sure if we can do much about the other cases, but if you also subtract the availLeft from the width, I think we're safe. It'd also be nice if the window didn't glued itself to the right border of the left-positioned Dock :-)

Comment 1

[[e-mail]]

(In reply to comment #0)
>if you also subtract the availLeft from the width, I think we're safe.
Hopefully we'd use availWidth which would already do that.

Comment 2

[Robert Kaiser]

We already use screen.availWidth, so I guess you should actually now have a bit more space at the right than what your dock uses at the left. Positioning right at the left edge of the available screen is what we actually _should_ do though, IMHO.

Comment 3

[Stefan [:stefanh]]

(In reply to comment #2)
> We already use screen.availWidth, so I guess you should actually now have a bit
> more space at the right than what your dock uses at the left. Positioning right
> at the left edge of the available screen is what we actually _should_ do
> though, IMHO.
> 

OK, then. What are the reasons? Just curious.

Comment 4

[Robert Kaiser]

(In reply to comment #3)
> OK, then. What are the reasons? Just curious.

IMHO, it's the place where one expects a newly started app to get displayed on most platforms. Additionally, the top left is probably the position where we can guarantee it to be visible even if the .avail* numbers somehow are reported wrong.

Comment 5

[Stefan [:stefanh]]

Attachment: use availLeft and screenX

This works fine on my mac. One oddity I found when testing this is that the width/height/screenX values doesn't seem to change and/or persist all the time. That is, if you resize/reposition the window and then close it, then open a new window, the position/size of the window is the same as it was the first time you opened it. 

It doesn't seem to be related to this bug because we never go into the if {..} block where we dynamically adjust the window, so obviously we do have a width attribute the second time the window is opened (which value seems to be the value we dynamically set the first time the window was opened). Anyway, it doesn't happens all the time and KaiRo just told me that this could be a new (known) issue on the whole mozilla-platform. It's supposed to be fixed very recently, so I guess I should update my tree.

Comment 6

[[e-mail]]

Comment on attachment 331119 [details] [diff] [review]
use availLeft and screenX

So, do we have to do anything special to avoid things docked at the top of the screen?

Comment 7

[Stefan [:stefanh]]

Attachment: Now with availTop as well

Comment 8

[Stefan [:stefanh]]

http://hg.mozilla.org/index.cgi/comm-central/rev/c9cdb6044b99