Closed Bug 433374 Opened 12 years ago Closed 12 years ago

[FIX]###!!! ASSERTION: Synchronous callback from necko: '!mLoader->mSyncCallback'

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1a1

People

(Reporter: cbook, Assigned: bzbarsky)

References

()

Details

(Keywords: assertion)

Attachments

(2 files)

Attached file stack
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051218 Minefield/3.0pre

Steps to reproduce:
-> Install the Tree Style Tab Extension https://addons.mozilla.org/en-US/firefox/addon/5890
-> Open the Option Window of this Extension
--> Assertion

###!!! ASSERTION: Synchronous callback from necko: '!mLoader->mSyncCallback', 
file c:/debug/mozilla/layout/style/nsCSSLoader.cpp, line 738
This seems to work fine for me on Linux (I get various other asserts, but not this one).

I guess I'll try on Mac, but the stack given really doesn't look like one that should be triggering this assertion, offhand.
Actually, I take that back.  Let me post a possible patch.  Carsten, would you be willing to test it?
Attached patch Like soSplinter Review
(In reply to comment #2)
> Actually, I take that back.  Let me post a possible patch.  Carsten, would you
> be willing to test it?
> 

Hi bz, yeah will do the tests, results asap - Tomcat 
Hi Boris, your patch fix the assertion for me, tested with Debug Builds on Mac and Windows XP
Version: unspecified → Trunk
Assignee: nobody → bzbarsky
Summary: ###!!! ASSERTION: Synchronous callback from necko: '!mLoader->mSyncCallback' → [FIX]###!!! ASSERTION: Synchronous callback from necko: '!mLoader->mSyncCallback'
Comment on attachment 320642 [details] [diff] [review]
Like so

This just makes sure to reset the debug boolean on the early return.
Attachment #320642 - Flags: superreview?(dbaron)
Attachment #320642 - Flags: review?(dbaron)
Comment on attachment 320642 [details] [diff] [review]
Like so

r+sr=dbaron
Attachment #320642 - Flags: superreview?(dbaron)
Attachment #320642 - Flags: superreview+
Attachment #320642 - Flags: review?(dbaron)
Attachment #320642 - Flags: review+
(Though really this should use a stack-allocated object to set and unset the boolean.)
Fixed.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a1
You need to log in before you can comment on or make changes to this bug.