433421 - Don't use nameless guard object

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

They don't work right :(

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/content/base/src/nsGenericElement.cpp&rev=3.651&mark=3248#3246

See bug 423269 comment 19

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think the result of this is slower performance under some circumstances. Mostly when using .replaceChild which is pretty rare. Might have worse consequences than performance, but I'm less sure about that.

So I don't think this is a blocker, but I do think we should fix this if there is another RC.

Comment 2

[Boris Zbarsky [:bzbarsky]]

This also affects document fragment (so innerHTML) performance, I would think.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

innerHTML creates its own batch, so it's unaffected.

Comment 4

[Mike Schroepfer]

Thanks for filing this jonas - if it turns out to worse please re-nom.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I think we should definitely take this on the branch...

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Agreed

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Peter fixed this way back in bug 540848