433449 - Last-updated date reads "Updated December 31, 1969" on /browse/ pages

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Steps to Reproduce:

1. Load https://preview.addons.mozilla.org/en-US/firefox/browse/type:1/cat:5
2. Look at the date after the add-on's description
3. Now click through (we'll use FlashGot: https://preview.addons.mozilla.org/en-US/firefox/addon/220) to its details page.

Actual Results:

The /browse/ page (step 2) reads, "Updated December 31, 1969"

Expected Results:

As when you click through to its details page (https://preview.addons.mozilla.org/en-US/firefox/addon/220), reads, "Updated April 4, 2008" (or something similar)

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

(This is from bug 425527, btw...)

Comment 2

[Fred Wenzel [:wenzel]]

The problem is that the fix from bug 425527 does not use the correct date field: it uses $version[0]['created'], no matter if that version even exists or what status it has.

In the Addon model, getAddonsByCategory() generates a "datestatuschanged" field that should be used where available.

Comment 3

[Wil Clouser [:clouserw]]

I think the problem was that the category landing page is it's own template and that variable wasn't getting passed in.  r13094 fixes this for the category landing page, theme landing page and the search engine page.

I think this bug is fixed, but holding off marking it that way till wenzel has a change to comment.

Comment 4

[Fred Wenzel [:wenzel]]

Ah yeah, I think that fixed it; however it does not address my points in comment 2, which arguably aren't this bug. I may file another bug or fix them here, hmmm.

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Using "datestatuschanged" in listitems

This patch will fix the "datestatuschanged" issue.

I will fix the "what status does the latest version even have?" problem as part of bug 404664 (this may not sound obvious, but I am quite sure it's the same problem).

Comment 6

[Wil Clouser [:clouserw]]

Shouldn't we check for that array key in each of the templates then?

Comment 7

[Fred Wenzel [:wenzel]]

Not sure if any other templates use that array key: it is generated by the Addon model's getAddonsByCategory() only when queried for a list of recently updated add-ons.

Comment 8

[Michael Morgan [:morgamic]]

Comment on attachment 320771 [details] [diff] [review]
Using "datestatuschanged" in listitems

wfm - ship it.

Comment 9

[Michael Morgan [:morgamic]]

(it works to fix this specific bug)

Comment 10

[Fred Wenzel [:wenzel]]

Checked into r13121. Thanks.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, w00t!