43345 - browser.cache.enable check

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect, P3)

Description

[Warren Harris]

Subject: 
        Re: browser.cache.enable
   Date: 
        Wed, 21 Jun 2000 14:01:27 -0400
   From: 
        [e-mail]
     To: 
        [e-mail] (Gagan Saksena)
    CC: 
        Warren Harris <[e-mail]>, [e-mail], 
[e-mail]





Warren,
We haven't done much to check how functional caching is on OS/2. I removed
this code in my build and the change doesn't hurt us.

Skip




[e-mail] (Gagan Saksena) on 06/21/2000 11:04:09 AM

To:   Warren Harris <[e-mail]>
cc:   [e-mail], [e-mail], Skip
      Nizinski/Austin/IBM@IBMUS
Subject:  Re: browser.cache.enable



Seems right to me. Skip could confirm if he needs this off for XP_OS2

-Gagan

Warren Harris wrote: I see some "temporary code" to check whether to enable
the cache in http channel, but it's ifdef'd for pc, mac and unix:

#if defined(XP_PC) || defined(XP_MAC) || defined(XP_UNIX)
        // Temporary code to disable cache on platforms where it is not
        // known to work
        static NS_DEFINE_CID(kPrefServiceCID, NS_PREF_CID);

        NS_WITH_SERVICE(nsIPref, prefs, kPrefServiceCID, &rv);
        PRBool useCache = PR_FALSE;
        if (NS_SUCCEEDED(rv))
            prefs->GetBoolPref("browser.cache.enable", &useCache);
        if (!useCache)
            return NS_OK;
#endif

Should we eliminate this ifdef now?

Warren

Comment 1

[Gagan]

->neeti

Comment 2

[neeti]

Nominating for nsbeta2

Comment 3

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 4

[Jay Patel [:jay]]

Let's get this done as soon as we can.

Comment 5

[neeti]

Checked in a fix

Comment 6

[Tom Everingham]

verified:
WinNT 2000071008