433470 - Unnecessary array filling in mailCommands.js deleteAllInFolder

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I've not found anything to go with this yet, and its been sitting in my tree for a week.

In mailCommands.js/deleteAllInFolder, we're going around an iterator filling up an nsISupportsArray, then we go round a loop (in the same order) acting on the elements.

I think this is just code left over from when I changed the subFolders function.

Comment 1

[Magnus Melin [:mkmelin]]

Comment on attachment 320676 [details] [diff] [review]
The fix

Nit: stray space after folder.propagateDelete(iter.getNext(), true, msgWindow); 

Other that that, looks good. r=mkmelin

Comment 2

[Mark Banner (:standard8)]

Patch checked in (with nit followed up).