43354 - XPInstall triggering isn't working. No installation.

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[David Epstein]

builds 2000-06-21-08-M17.
1. Go to http://jimbob/trigger3.html
2. Select any test case. Or enter .xpi in the URL field.
3. Press Trigger.
4. Confirm dialog appears. (on NT, the module box is empty). Press OK.

Result: Nothing happens. Progress dialog doesn't appear, nothing gets installed.

Comment 1

[David Epstein]

change qa contact to depstein. nominating nsbeta2 and dogfood.

Comment 2

[Jimmy Lee]

The problem appears from build 2000-06-20-21-M17(WIN).  The earlier build from 
6/20/00 does work though.

Comment 3

[Daniel Veditz [:dveditz]]

Clicking on a xpi link (with server using the right MIME type) works, the 
problem is only when you use a JavaScript trigger to launch this. Due to new 
security checks our confirmation dialog is not treated as modal. Since the 
install then continues on before the dialog has had a chance to come up and set 
the "do the install" flag the default value of "cancel" is used instead.

This is a known problem (affects alerts, too, apparently) but according to 
mstoltz may require something special to account for our dialog so it's not 
quite a duplicate. Reassigning to joki per mstoltz

This bug blocks installation of PSM for Mozilla folks

Comment 4

[Jay Patel [:jay]]

Is this a dup of 43272? Putting on [nsbeta2-][dogfood-] radar.

Comment 5

[Daniel Veditz [:dveditz]]

No, error -229 in bug 43272 means the script ran but encountered errors. This 
one the script doesn't run at all because the non-modality of our confirmation 
dialog makes it appear the user disallowed the install (reported as -210).

Appealing dogfood and nsbeta2 decisions because no reasons were given and it's 
not clear that you understand that this kills
 1) the current PSM page for mozilla users
 2) our plan for the Netcenter SmartUpdate site in PR2
 3) daily testing (inconvenient workaround available except when off-line)
 4) plans for skin/theme installs
 5) plans for additional language pack installs

Think about it guys -- no skin installs!

Comment 6

[Jim Roskind]

Doesn't stop daily use by most developers (they don't install PSM, they build 
it and use it, or download in the commercial build) so we went dogfood-.

Skins install, along with smart update, gets us on the beta2 plus radar.

Comment 7

[Jimmy Lee]

FYI...This bug blocks QA's daily automated test scripts.
We fall back into manual testing using mime type support.

Comment 8

[joki (gone)]

The modal dialog from script issue has been fixed as part of bug 43390.  This 
should now work.

Comment 9

[joki (gone)]

*** Bug 43272 has been marked as a duplicate of this bug. ***

Comment 10

[David Epstein]

fixed cross-platform: WinNT, Win98, Linux, and Mac. builds 2000-06-26-08-M17. In 
Windows, confirm dlog is still blank.