Closed
Bug 433551
Opened 17 years ago
Closed 17 years ago
Accesskey for updater menuitem in Help menu isn't set properly for its various labels
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.0a1
People
(Reporter: wladow, Assigned: wladow)
Details
Attachments
(2 files, 1 obsolete file)
12.83 KB,
image/png
|
Details | |
747 bytes,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
Check for updates menuitem has several different labels depending on update process state. Each label has its own accesskey, but only initial accesskey is used. Fix follows.
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #320759 -
Flags: review?(neil)
![]() |
||
Comment 2•17 years ago
|
||
Thanks wladow? As we probably ported this code from FF, could you take a look if the same error is in their code as well and if so, file a bug?
Assignee | ||
Comment 3•17 years ago
|
||
They don't use separate accesskey for each label, but I do plan file bug on it and implement this. This is definetely better approach.
![]() |
||
Comment 4•17 years ago
|
||
Thanks a lot!
I'm proud of SeaMonkey (or actually you looking at our product) spotting and first fixing this, but in the end, we should still care for our small brother Firefox being fixed as well - we are porting enough good stuff the other way as well.
Given that FF is in 3.0rc stage already, it might be a good idea to file the bug already now so they can possibly get it for 3.0 final.
Assignee | ||
Comment 5•17 years ago
|
||
They can't get it for 3.0, because it's string frozen. Firefox uses single accesskey for all updater labels, so when implementing this, we will have to add new accesskeys into locale file. This will be possible only for Firefox.next I suppose.
Comment 6•17 years ago
|
||
Comment on attachment 320759 [details] [diff] [review]
v1
Is the problem just that the accessKey property has been mistyped in lower case?
Assignee | ||
Comment 7•17 years ago
|
||
Obviously yes, here is updated fix
Attachment #320759 -
Attachment is obsolete: true
Attachment #320884 -
Flags: review?(neil)
Attachment #320759 -
Flags: review?(neil)
Comment 8•17 years ago
|
||
Comment on attachment 320884 [details] [diff] [review]
v2
Thanks.
Attachment #320884 -
Flags: review?(neil) → review+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
![]() |
||
Comment 9•17 years ago
|
||
Heh, ok, thanks. So we already have the accesskey definitions but a typo in the code, and FF is still lacking the definitions as well. Good to know that :)
Comment 10•17 years ago
|
||
patch checked into CVS
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 11•17 years ago
|
||
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9pre) Gecko/2008051506 Minefield/3.0pre
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 12•17 years ago
|
||
ehm, with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9pre) Gecko/2008052302 SeaMonkey/2.0a1pre of course.
You need to log in
before you can comment on or make changes to this bug.
Description
•