Closed Bug 433551 Opened 16 years ago Closed 16 years ago

Accesskey for updater menuitem in Help menu isn't set properly for its various labels

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.0a1

People

(Reporter: wladow, Assigned: wladow)

Details

Attachments

(2 files, 1 obsolete file)

Attached image screenshot
Check for updates menuitem has several different labels depending on update process state. Each label has its own accesskey, but only initial accesskey is used. Fix follows.
Attached patch v1 (obsolete) — Splinter Review
Attachment #320759 - Flags: review?(neil)
Thanks wladow? As we probably ported this code from FF, could you take a look if the same error is in their code as well and if so, file a bug?
They don't use separate accesskey for each label, but I do plan file bug on it and implement this. This is definetely better approach. 
Thanks a lot!
I'm proud of SeaMonkey (or actually you looking at our product) spotting and first fixing this, but in the end, we should still care for our small brother Firefox being fixed as well - we are porting enough good stuff the other way as well.
Given that FF is in 3.0rc stage already, it might be a good idea to file the bug already now so they can possibly get it for 3.0 final.
They can't get it for 3.0, because it's string frozen. Firefox uses single accesskey for all updater labels, so when implementing this, we will have to add new accesskeys into locale file. This will be possible only for Firefox.next I suppose.
Comment on attachment 320759 [details] [diff] [review]
v1

Is the problem just that the accessKey property has been mistyped in lower case?
Attached patch v2Splinter Review
Obviously yes, here is updated fix
Attachment #320759 - Attachment is obsolete: true
Attachment #320884 - Flags: review?(neil)
Attachment #320759 - Flags: review?(neil)
Comment on attachment 320884 [details] [diff] [review]
v2

Thanks.
Attachment #320884 - Flags: review?(neil) → review+
Keywords: checkin-needed
Heh, ok, thanks. So we already have the accesskey definitions but a typo in the code, and FF is still lacking the definitions as well. Good to know that  :)
patch checked into CVS
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9pre) Gecko/2008051506 Minefield/3.0pre
Status: RESOLVED → VERIFIED
ehm, with Mozilla/5.0 (Windows; U; Windows NT 6.0; sk; rv:1.9pre) Gecko/2008052302 SeaMonkey/2.0a1pre of course.
You need to log in before you can comment on or make changes to this bug.