Closed Bug 433619 Opened 12 years ago Closed 12 years ago

Reminder flag for compact folder popup ineffective when clicking "NO"


(MailNews Core :: Backend, defect, P3)



(Not tracked)

Thunderbird 3.0b2


(Reporter: eddy_nigg, Assigned: mkmelin)



(2 files, 2 obsolete files)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5
Build Identifier: 3.0a2pre (2008051203)

Occasional popup window questioning if to compact the current folder keeps appearing even after flagging the select box "Do this from now on automatically" and after clicking "NO". Doesn't remember the decision.

Reproducible: Always

Steps to Reproduce:
1. Set Preferences -> Advanced -> Network & Disk Space -> Disk Space to "ON" and some low value.
2. Wait for the popup appear 
3. Select the flag and select "NO"
4. Wait for the next popup appear over and over again
Actual Results:  
Keeps bugging about compacting the folder. Doesn't remember previous decision.

Expected Results:  
Should stop bugging about it. Should remember the decision after selecting the flag to do this from now on automatically.

Also the phrase next to the flag could be improved, because it somehow expects that compacting the folder is the only logical decision.

Intrusive and annoying :-)
Component: Preferences → MailNews: Backend
Ever confirmed: true
OS: Linux → All
Product: Thunderbird → Core
QA Contact: preferences → backend
Hardware: PC → All
Target Milestone: --- → mozilla1.9.1a1
Attached patch proposed fix (obsolete) — Splinter Review
Change this to similar wording/functionality to what thunderbird uses for Offline | Work Offline 

Bad idea to have the "this" in the checkbox wording mean different things depending on what you click.
Assignee: nobody → mkmelin+mozilla
Attachment #329285 - Flags: superreview?(neil)
Attachment #329285 - Flags: review?(neil)
Priority: -- → P3
Comment on attachment 329285 [details] [diff] [review]
proposed fix

>            if (!buttonPressed)
>-           {
>              okToCompact = PR_TRUE;
>-             if (checkValue)
>-               branch->SetBoolPref(PREF_MAIL_PURGE_ASK, PR_FALSE);
>-           }
>+           if (!checkValue) // [ ] Always ask me before compacting folders automatically
>+             branch->SetBoolPref(PREF_MAIL_PURGE_ASK, PR_FALSE);
I don't like this change. It means that if you don't want to compact folders, you could accidentally prevent it from asking you next time.
Attachment #329285 - Flags: superreview?(neil)
Attachment #329285 - Flags: superreview-
Attachment #329285 - Flags: review?(neil)
Well, only if you bother unchecking the checkbox first, which makes the accident  a bit of a stretch.

Honoring the checkbox only for "yes" would make this dialog work a different way than the thunderbird going offline ones like
Product: Core → MailNews Core
... and so does the "Empty Junk"/"Empty Trash" do it. 

I'm not sure why you're worried about an accidentally disabling the dialog? Honoring the checkbox even with "No" what this bug was about mainly. 
Frankly I think very few users use this option, and having this dialog pop up all the time would seem to be very annoying.

Then again, maybe the wording on the buttons should also be improved to use verbs?

 Do you wish to compact all local and offline folders to save disk space?
 [x] Always ask me before compacting folder automatically

                                               [ Cancel ] [ Compact now ]

Of course, in the long run we should probably remove the UI (bug 286888) but there are various issues which makes it not possible just yet - see comments in that bug.
Attached patch proposed fix, v2Splinter Review
Attachment #329285 - Attachment is obsolete: true
Attachment #329286 - Attachment is obsolete: true
Attachment #355844 - Flags: ui-review?(clarkbw)
Attachment #355844 - Flags: superreview?(neil)
Attachment #355844 - Flags: review?(neil)
Attached image screenshot, v2
Target Milestone: mozilla1.9.1a1 → Thunderbird 3.0b2
Attachment #355844 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 355844 [details] [diff] [review]
proposed fix, v2

action text buttons!  looks much better
Comment on attachment 355844 [details] [diff] [review]
proposed fix, v2

>-             if (checkValue)
>+             if (!checkValue) // [ ] Always ask me before compacting folders automatically
This behaviour change could do with a better variable name, e.g. alwaysAsk, and possibly a better locale string name too, e.g. autoCompactAlwaysAsk (but feel free to think of even better names than my suggestions).
Attachment #355844 - Flags: superreview?(neil)
Attachment #355844 - Flags: superreview+
Attachment #355844 - Flags: review?(neil)
Attachment #355844 - Flags: review+
changeset:   1614:09e5816364bf

Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.