433622 - fix broken aspects of Mozilla.com for Solaris users

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[John Slater]

I've gotten a report that the logo and download button aren't appearing when you load mozilla.com on a Solaris computer.

Steven, can you investigate? Obviously the ideal solution would be to fix this on the current site and the upcoming FF3 site, but the FF3 site is the higher priority.

Thanks!

Comment 1

[John Slater]

Attachment: Solaris screenshot

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

I got some more information from a community member, timeless, who sent this info along with an identical screenshot, on request:

SunOS swift 5.11 snv_53 i86pc i386 i86pc
Build identifier: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.8.1)
Gecko/2006111315 Firefox/2.0
javascript:navigator.userAgent == Mozilla/5.0 (X11; U; SunOS i86pc;
en-US; rv:1.8.1) Gecko/20061113 Firefox/2.0

This is running w/ the Exceed x server (win32)

Comment 3

[Reed Loden [:reed]]

What's javascript:navigator.platform?

Comment 4

[Alfred Peng]

On a SPARC box with Solaris Express Community Edition snv_89:
javascript:navigator.userAgent == Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8.1.14) Gecko/20080421 Firefox/2.0.0.14
javascript:navigator.platform == SunOS sun4u

Comment 5

[Alfred Peng]

On a x86 box with Solaris Express Community Edition snv_87:
javascript:navigator.userAgent == Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9b5) Gecko/2008040716 Firefox/3.0b5
javascript:navigator.platform == SunOS i86pc

Comment 6

[timeless]

note that sniffing for 'sun4u' is a terrible idea.
http://www.ocf.berkeley.edu/solaris/versions/
sun4u, sun4v

it's probably safe to sniff for /\bsun4/ or /^SunOS sun4/

given:
http://news.com.com/Sun,+Intel+part+ways+on+Solaris+plans/2100-1001_3-243489.html

you don't have to worry about ia64 (unless someone contributes it to opensolaris in the future).

Do *not* simply sniff for SunOS, as there are ports planned for a couple of other hardware platforms :).

you should be able to navigator.platform == 'SunOS i86pc' for x86 (including x86-64).

Comment 7

[Alfred Peng]

Guys, any progress on this? The Solaris contributed builds for RC1 and RC2 have been uploaded. I assume that the final release will be made soon.

Also notice that there will be an event to set the world record for download: http://www.spreadfirefox.com/en-US/worldrecord. And some Solaris guys are pretty interested. Will the Solaris contributed builds download be part of the number?

Comment 8

[John Slater]

Marking as target milestone 3.0 - let's try to fix for the new site, but I'm not too concerned with the current site at this point (given that it will be frozen while Wil Clouser merges the branches starting tomorrow, and won't be in use for much longer).

Comment 9

[Steven Garrity [:sgarrity]]

Reed - can you take this?

Comment 10

[Alfred Peng]

As this issue is targeted to Firefox 3.0, it should depend on bug 438796.

Comment 11

[Alfred Peng]

Notice that this links have been provided in http://www.mozilla.com/en-US/firefox/3.0/releasenotes/#contributedbuilds. Thanks for that!

Any update for the mozilla.com logo issue?

Comment 12

[John Slater]

Hey guys. Just checking back in on this. It's been awhile, and Alfred has been very patient, but it would be nice to resolve this one soon.

Reed, any thoughts on next steps?

Thanks,
John

Comment 13

[Reed Loden [:reed]]

I can try to work on this, but I'm not sure when I'll get a chance. My schedule is pretty busy right now.

Comment 14

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Except for the "Free Download" link not having any sort of green box around it (its only a blue link on the light blue background image), http://www.mozilla.com/en-US/ works for me on a

SunOS <hostname> 5.10 Generic_127111-07 sun4u sparc SUNW,Sun-Fire-V490

with both firefox 2.0.0.8 and 3.0.3

Comment 15

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Any update on this?

Comment 16

[Reed Loden [:reed]]

(In reply to comment #15)
> Any update on this?

Nope, and I have no idea when I'm going to have time to get to this.

Comment 17

[Alfred Peng]

Attachment: proposal one

Comment 18

[Alfred Peng]

Attachment: proposal two

Comment 19

[Alfred Peng]

The Mozilla download page has just been set up in OpenSolaris community: http://opensolaris.org/os/community/desktop/communities/mozilla/development/. It highlights all the Solaris contributed builds with pointers to Mozilla bouncer.

With this download page ready, I'd like to update the previous proposal in bug 461118 as below:

1. Update the www.mozilla.com main page to link Solaris users to the Mozilla download page in OpenSolaris community (attachment "proposal one"). Please note that this change should only affect the users on Solaris/OpenSolaris. And they can rely on the OpenSolaris community to provide the contributed builds and support. This option is preferred.

2. Update the release notes of every Firefox/Thunderbird official releases to include the pointer for the Mozilla download page in OpenSolaris community (attachment "proposal two"). However, this is an inferior choice to compare with the first option. The Solaris users will have to go through several clicks to get the builds.

One way or another, Solaris users could get better download support. OpenSolaris Desktop team will be responsible for maintaining the download page. Any suggestions will be appreciated.

Comment 20

[Wil Clouser [:clouserw]]

Your patch won't work as is but isn't far off.  We need a reliable way to detect Solaris from JavaScript.  What can we look for?  (e.g. SunOS, Solaris, ?)

Comment 21

[Alfred Peng]

clouserw, thanks for the feedback. The patch for proposal one was a tentative one to show the idea. Actually I searched in the mozilla.com svn code and can't find the definition of PLATFORM_MACOSX and gPlatform.

On Solaris, the value of navigator.platform is 'SunOS'. So it might be good to update the patch to:
+        if (gPlatform == 'SunOS') {

Is this what we are looking for?

Comment 22

[Alfred Peng]

(In reply to comment #21)
> On Solaris, the value of navigator.platform is 'SunOS'. So it might be good to
> update the patch to:
> +        if (gPlatform == 'SunOS') {
> 
> Is this what we are looking for?

Oops, a correction. navigator.platform is 'SunOS i86pc' on Solaris. navigator.platform.substring(0,5) == 'SunOS'.

Comment 23

[Wil Clouser [:clouserw]]

Attachment: proposal one

Here is a patch that implements a (mostly) working proposal one for /firefox/

Comment 24

[Wil Clouser [:clouserw]]

Attachment: screenshot

And here's the problem - there is too much text.

Comment 25

[Alfred Peng]

clouserw, thanks for the patch!

(In reply to comment #24)
> And here's the problem - there is too much text.

Maybe we could update the string to Contributed by OpenSolaris.org. Is that helpful?

Comment 26

[Wil Clouser [:clouserw]]

That fixes it for me.  This is on trunk in r24580.  We need r=QA before pushing live.

https://www-trunk.stage.mozilla.com/en-US/firefox/firefox.html

Comment 27

[Stephen Donner [:stephend] Not actively reading bugmail]

I set my useragent to Mozilla/5.0 (X11; U; SunOS i86pc; en-US;
rv:1.9b5) Gecko/2008040716 Firefox/3.0b5 (via general.useragent.override in about:config), and still get the download page for Windows -- how do I test this?

(I've tested that we haven't regressed, and that's looking fine.)

Comment 28

[Wil Clouser [:clouserw]]

You need general.platform.override

Comment 29

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks good to me, once I set up general.platform.override (comment 28); I now see the button for OpenSolaris, and its link points to http://opensolaris.org/os/community/desktop/communities/mozilla/development/.

Comment 30

[Wil Clouser [:clouserw]]

This is on stage, marking this fixed.  Slater, if you're happy with it please push these files live:

/js/download.old.js
/en-US/firefox/firefox.html

Comment 31

[John Slater]

(In reply to comment #30)
> This is on stage, marking this fixed.  Slater, if you're happy with it please
> push these files live:
Done!

Comment 32

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #31)
> (In reply to comment #30)
> > This is on stage, marking this fixed.  Slater, if you're happy with it please
> > push these files live:
> Done!

It's been an hour and I still don't see this on production.

Comment 33

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot, post-fix

I'm now seeing "Unknown" as the platform on both trunk and production (this was working fine in trunk before).

Comment 34

[Wil Clouser [:clouserw]]

(In reply to comment #33)
> I'm now seeing "Unknown" as the platform on both trunk and production (this was
> working fine in trunk before).

You're looking at a different URL.  I pushed a fix onto trunk with the caveat that the filesize is unknown so the parenthesis after the language are empty.  The fix is only /js/download.old.js

Comment 35

[Alfred Peng]

I can see the same behavior as stephend on my OpenSolaris box by visiting (http://www.mozilla.com/en-US/) with Firefox 3.1b3 "Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.9.1b3) Gecko/20090326 Firefox/3.1b3", and the download button points to http://www.mozilla.com/en-US/firefox/all.html now. Will there be an update to this?

Comment 36

[Wil Clouser [:clouserw]]

(In reply to comment #35)
> I can see the same behavior as stephend on my OpenSolaris box by visiting
> (http://www.mozilla.com/en-US/) with Firefox 3.1b3 "Mozilla/5.0 (X11; U; SunOS
> i86pc; en-US; rv:1.9.1b3) Gecko/20090326 Firefox/3.1b3", and the download
> button points to http://www.mozilla.com/en-US/firefox/all.html now. Will there
> be an update to this?

It's fixed on trunk: https://www-trunk.stage.mozilla.com/en-US/

Comment 37

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: screenshot; still seeing empty () after English (US)

Comment 38

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening per comment 37.

Comment 39

[Stephen Donner [:stephend] Not actively reading bugmail]

Oh, you said that in comment 34, duh; looks fine otherwise -- maybe you should mark it fixed again, Wil?  Will the file size be added in manually to product-details later?

Comment 40

[Alfred Peng]

Should the page look like the screenshot in Comment 24? The text is something similar to "3.0.8 for OpenSolaris\n Contributed by OpenSolaris.org" instead of "3.0.8 for SunOS\n English(US)..."?

Comment 41

[Wil Clouser [:clouserw]]

(In reply to comment #39)
> Oh, you said that in comment 34, duh; looks fine otherwise -- maybe you should
> mark it fixed again, Wil?  Will the file size be added in manually to
> product-details later?

I don't have a way of knowing the file size.  If Alfred wants to give me an estimate I can fill that in but it's not something I want to maintain.

(In reply to comment #40)
> Should the page look like the screenshot in Comment 24? The text is something
> similar to "3.0.8 for OpenSolaris\n Contributed by OpenSolaris.org" instead of
> "3.0.8 for SunOS\n English(US)..."?

You're looking at two different URLs and two different buttons.  So, no.

Comment 42

[Alfred Peng]

(In reply to comment #41)
> I don't have a way of knowing the file size.  If Alfred wants to give me an
> estimate I can fill that in but it's not something I want to maintain.

The file size for Firefox 3.0.x/3.1beta builds are about 17MB as I check. I think we can put 17MB as an estimate value.

BTW, as the fix is in stage (which I can't access), guess Slater needs to push it to production again.

Comment 43

[Stephen Donner [:stephend] Not actively reading bugmail]

Looks fine on https://www-trunk.stage.mozilla.com/en-US/firefox/firefox.html; there are other bugs to file (Alfred, would you mind doing this so they don't get lost?):

* empty size "()" in the homepage's button (comment 41 -- Wil, are you going to add that now?)
* button-name mismatch in comment 41, as Wil already notes
* clicking on the Firefox 3.5 logo from the homepage takes me to /firefox, and I get a 302 to https://www-trunk.stage.mozilla.com/en-US/firefox/personal.html, which doesn't offer Solaris builds at all -- just loading https://www-trunk.stage.mozilla.com/en-US/firefox/firefox.html directly, though, works

I'm assuming that since Wil marked this fixed the above issues will have to be spun-off.  What we have now should be pushed since it fixes bugs, though.

Verified FIXED.

Comment 44

[Alfred Peng]

Stephen, sure. I'll file another bug to track all the remaining issues in comment 43.

BTW, when can we expect a push? Currently, the button on http://www.mozilla.com/en-US/ points to http://www.mozilla.com/en-US/firefox/all.html (on Solaris) which is quite confusing for Solaris users I think.

Comment 45

[Stephen Donner [:stephend] Not actively reading bugmail]

I've tested this and it's ready to go -- John, Wil, Steven, or someone else can push the changes.(In reply to comment #44)

> Stephen, sure. I'll file another bug to track all the remaining issues in
> comment 43.
> 
> BTW, when can we expect a push? Currently, the button on
> http://www.mozilla.com/en-US/ points to
> http://www.mozilla.com/en-US/firefox/all.html (on Solaris) which is quite
> confusing for Solaris users I think.

Comment 46

[John Slater]

I can push the changes...which specific files need pushing?

Comment 47

[Alfred Peng]

(In reply to comment #46)
> I can push the changes...which specific files need pushing?

Wil, could you please shed some light?

Comment 48

[Wil Clouser [:clouserw]]

It's just /js/download.old.js

Comment 49

[John Slater]

(In reply to comment #48)
> It's just /js/download.old.js
Done!

Comment 50

[Alfred Peng]

Verified.

And a new bug 490308 has been filed to track the remaining issues mentioned in comment 43. Thanks for the help, guys!