43365 - Crash-clicking in list bucket for Abook list, this is regression

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P1)

Description

[esther]

Using build 2000-06-20 on win and linux only, I crash when I click in the list 
bucket in an Address Book list window.  

1. launch messenger
2. Open address book
3. Click on New List
4. Click in the list area where you are suppose to add names.  

Result: I crash
Expected: to get a text entry box in the list area for typing in a name.
Will try to get a talkback and post it.

Comment 1

[Suresh]

and the stack trace...

nsXULTreeOuterGroupFrame::EnsureRowIsVisible(int 1) line 760 + 18 bytes
nsXULTreeFrame::EnsureRowIsVisible(nsXULTreeFrame * const 0x03c11d64, int 1) 
line 117
nsTreeBoxObject::EnsureIndexIsVisible(nsTreeBoxObject * const 0x045daef0, int 1) 
line 116 + 27 bytes
XPTC_InvokeByIndex(nsISupports * 0x045daef0, unsigned int 3, unsigned int 1, 
nsXPTCVariant * 0x0012ee0c) line 139
nsXPCWrappedNativeClass::CallWrappedMethod(JSContext * 0x044975f0, 
nsXPCWrappedNative * 0x045da120, const XPCNativeMemberDescriptor * 0x045da234, 
nsXPCWrappedNativeClass::CallMode CALL_METHOD, unsigned int 1, long * 
0x03bfb9f4, long * 0x0012efbc) line 914 + 43 bytes
WrappedNative_CallMethod(JSContext * 0x044975f0, JSObject * 0x032040c8, unsigned 
int 1, long * 0x03bfb9f4, long * 0x0012efbc) line 200 + 34 bytes
js_Invoke(JSContext * 0x044975f0, unsigned int 1, unsigned int 0) line 686 + 23 
bytes
js_Interpret(JSContext * 0x044975f0, long * 0x0012f974) line 2490 + 15 bytes
js_Execute(JSContext * 0x044975f0, JSObject * 0x01377898, JSScript * 0x045d9360, 
JSFunction * 0x00000000, JSStackFrame * 0x00000000, unsigned int 0, long * 
0x0012f974) line 857 + 13 bytes
JS_EvaluateUCScriptForPrincipals(JSContext * 0x044975f0, JSObject * 0x01377898, 
JSPrincipals * 0x0194ff44, const unsigned short * 0x0012fa30, unsigned int 14, 
const char * 0x045d9470, unsigned int 431, long * 0x0012f974) line 2754 + 27 
bytes
nsJSContext::EvaluateString(nsJSContext * const 0x04495e20, const nsString & 
{...}, void * 0x01377898, nsIPrincipal * 0x0194ff40, const char * 0x045d9470, 
unsigned int 431, const char * 0x002fb468, nsString & {...}, int * 0x0012fa14) 
line 465 + 55 bytes
GlobalWindowImpl::RunTimeout(nsTimeoutImpl * 0x045d9520) line 3340 + 97 bytes
nsGlobalWindow_RunTimeout(nsITimer * 0x045d9410, void * 0x045d9520) line 3605 + 
15 bytes
nsTimer::Fire() line 194 + 17 bytes
FireTimeout(HWND__ * 0x00000000, unsigned int 275, unsigned int 1755, unsigned 
long 2523111242) line 78
USER32! 77e7185c()
nsAppShellService::Run(nsAppShellService * const 0x018e67d0) line 387
main1(int 1, char * * 0x010c4800, nsISupports * 0x00000000) line 906 + 32 bytes
main(int 1, char * * 0x010c4800) line 1092 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77f1ba06()

Comment 2

[esther]

I know this worked on the 6-16 build, not sure when it broke again

Comment 3

[chuang]

This is caused by the new tree widget landing on 6/19.  I have checked in the 
fix for mailing list dialog today.  On my debug build, it is fine on all three 
platforms.  Please verify on tomorrow's build (6/22/00).

Comment 4

[esther]

ducarroz says this needs another fix.  He has it, reassigning to him.

Comment 5

[esther]

reassigning ducarroz

Comment 6

[Jean-Francois Ducarroz]

The new tree widget crash when it doesn't have any row because it's doing a div 
per 0.

Comment 7

[Jean-Francois Ducarroz]

Here is the patch:

S:\mozilla\layout\xul\base\src>cvs diff nsXULTreeOuterGroupFrame.cpp
Index: nsXULTreeOuterGroupFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/xul/base/src/nsXULTreeOuterGroupFrame.cpp,v
retrieving revision 1.8
diff -r1.8 nsXULTreeOuterGroupFrame.cpp
321c321,323
<   PRInt32 visibleRows = GetAvailableHeight()/mRowHeight;
---
>   PRInt32 visibleRows = 0;
>   if (mRowHeight)
>       visibleRows = GetAvailableHeight()/mRowHeight;
760c762,764
<   PRInt32 rows = GetAvailableHeight()/mRowHeight;
---
>   PRInt32 rows = 0;
>   if (mRowHeight)
>     rows = GetAvailableHeight()/mRowHeight;

Comment 8

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 9

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 10

[esther]

Using build 2000-06-26 on win98, mac and linux this is fixed. Verified.