433690 - nominated word by spell checker disappear on the context menu in the writing window

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Shadow912]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.14) Gecko/20080404 Firefox/2.0.0.14
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051303 Thunderbird/3.0a2pre

When composing message, typing wrong word and right-click, Tb show nominated word on the context menu.
But installed extension with adding menu item and popup menu on the context menu in   message compose window, and move cursor to the extension's menu time.
So nominated word disappear.


Reproducible: Always

Steps to Reproduce:
1.Install extension with adding menu item/popup menu on the context menu in message compose window.(e.g Signature Switch, ConQuery...).
2.Type wrong word and right-click in the message compose window, Tb show nominated word.
3.Move cursor to the extension's menu item.
Actual Results:  
Nominated word disappear.


On the Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.14) Gecko/20080421 Thunderbird/2.0.0.14
and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.15pre) Gecko/20080513 Thunderbird/2.0.0.15pre,
error occurred in the error console as follows:
-----
Error: uncaught exception:
 [Exception... "Component returned failure code: 0x8000ffff
 (NS_ERROR_UNEXPECTED) [nsIDOMXULDocument_MOZILLA_1_8_BRANCH.popupRangeParent]"
  nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
 chrome://messenger/content/messengercompose/MsgComposeCommands.js ::
 openEditorContextMenu :: line 616"  data: no]
-----

And do same steps on the text box/area in Firefox 2.0.0.14/3 beta 5, doesn't disappear nominated word and no error.

Comment 1

[Shadow912]

Attachment: Simple extension sample with menu item/popup menu on the context menu

Simple extension sample with menu item/popup menu on the context menu for checking.
This is written only XUL overwrite, no JavaScript.

Comment 2

[Atsushi Sakai]

Attachment: Patch v1.0

This patch fixes the problem.
But fixing this on add-ons side might be better because |event.target == this| is always true without add-ons.

Comment 3

[Shadow912]

Thanks Mr.Sakai for patch.(In reply to comment #2)

> But fixing this on add-ons side might be better because |event.target == this|
> is always true without add-ons.

I don't think so, because all developers should fix their extensions with popup menu on context menu in the message compose window, if this problem exist.
And fixed code in the those extensions are same and waste.

You worry about evaluation is always true, I think that's better changing the code and evaluation as follows.
-----
<popup id="msgComposeContext" onpopupshowing="if (event.target != this) return; openEditorContextMenu(this);">
-----

And this is the same code as browser.xul on the Firefox 2/3.

Comment 4

[Atsushi Sakai]

Attachment: Patch v1.0.1

modified patch addressed Comment 3

I won't go to review process because I don't know whether this is the right thing.
But if you think this fix is needed, feel free to use this patch as you like.

Comment 5

[Shadow912]

Attachment: Patch v1.0.2

I'll go to review process with this patch.
Patch v1.0.2 is the same as v1.0.1 created by Mr.Sakai, tanks.

Comment 6

[Shadow912]

(In reply to comment #5)
> Patch v1.0.2 is the same as v1.0.1 created by Mr.Sakai, tanks.
Oops... sorry, "tanks" was a typo.
Thanks for your patch, Mr.Sakai.

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 322235 [details] [diff] [review]
Patch v1.0.1

Yes this looks correct, though I think return true is better than simple return.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 322349 [details] [diff] [review]
Patch v1.0.2

No need to submit the same patch twice.

Comment 9

[Magnus Melin [:mkmelin]]

Thx for the fix. I've checked it in.

Checking in mail/components/compose/content/messengercompose.xul;
/cvsroot/mozilla/mail/components/compose/content/messengercompose.xul,v  <--  messengercompose.xul
new revision: 1.124; previous revision: 1.123
done

->FIXED

Comment 10

[Shadow912]

Thx for the review and commitment. Works well on the trunk.