433739 - 'Browse Search Engines' link not working on p.a.m.o.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Mycroft Project (CC)]

https://preview.addons.mozilla.org/en-US/firefox/browse/type:4 the link 'Browse Search Engines' (https://preview.addons.mozilla.org/en-US/firefox/browse/type:4/cat:all?sort=name) seems to return all addons - well okay, everything *except* any search engines

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Chris, is this something you could take last-minute for 3.4.2?

Comment 2

[Mycroft Project (CC)]

(It's a regression cf. a.m.o.)

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Did this regress from bug 426085?

Comment 4

[Chris Pollett]

Hey Wenzel, 

        // cat:all shows all valid add-on types, only the selected one otherwise
        if ($category != 'all') {
            $this->Tag->unbindFully();
            $this_tag = $this->Tag->findById($category);
            $this_addon_type = $this->Addontype->findById($addontype);
        } else {
            $this_tag = array();
            $this_addon_type = array();
            $addontype = $app_listedtypes[APP_ID];
        }

from Bug 425481 causes this problem. If I get rid of the if to make:
            $this->Tag->unbindFully();
            $this_tag = $this->Tag->findById($category);
            $this_addon_type = $this->Addontype->findById($addontype);
it reverts to the original behavior. This bug also causes problems for any
of the "I am looking for" links

You probably had a good reasons though for the if statement so I was wondering if you could look at it.

Comment 5

[Fred Wenzel [:wenzel]]

Oh, indeed, I broke this with the fix for bug 425481. Apologies, I am taking this and fixing it right away. Thanks for pointing me to it, Chris.

The reason for the "if" was that for the global "newest" and "updated" and "popular" lists, people would like to see all valid add-on types, not only extensions (in spite of the URL containing type:1).

Comment 6

[Fred Wenzel [:wenzel]]

Attachment: Fixing "browse all" lists

Chris, could you take a look at this? Now it should work as intended, showing all valid add-on types for the "type:1" list, and maintaining the original behavior everywhere else.

Comment 7

[Chris Pollett]

Comment on attachment 321034 [details] [diff] [review]
Fixing "browse all" lists

WFM so r+

Comment 8

[Fred Wenzel [:wenzel]]

Thanks. Commmitted to r13199.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED, and I made sure I also spot-checked other links on this page.