433740 - itemDeleted event not fired when item is deleted from trash

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch to call itemDeleted() for messages deleted individually from trash

(local mail folders)

When an item is deleted from trash, an itemDeleted notification is not sent for the message.

The itemDeleted notification works for messages shift-deleted from mail folders, or for the Empty Trash option, but not for messages deleted individually from trash.

The patch fixes this by adding a check to find out whether the item is deleted from the trash.

Comment 1

[Rain [:rain1] (inactive)]

Attachment: [checked in] updated patch, fixes coding style issue

Comment 2

[Magnus Melin [:mkmelin]]

Thanks for the patch, Siddharth!

Checking in mailnews/local/src/nsLocalMailFolder.cpp;
/cvsroot/mozilla/mailnews/local/src/nsLocalMailFolder.cpp,v  <--  nsLocalMailFolder.cpp
new revision: 1.581; previous revision: 1.580
done

->FIXED

Comment 3

[Magnus Melin [:mkmelin]]

And i don't know what's up with cvs, or perhaps bonsai, the checkin comment looks normal here...

Comment 4

[Rain [:rain1] (inactive)]

Attachment: [checked in] patch to fix regression introduced in moving items out of trash

The patch also caused an extra itemDeleted to be fired when an item was moved out of the trash into a folder. While the itemDeleted is quite harmless (an itemMoveCopyCompleted is also fired for the same messages before the itemDeleted), it's a good idea to fix this.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 323346 [details] [diff] [review]
[checked in] patch to fix regression introduced in moving items out of trash

Checking in mailnews/local/src/nsLocalMailFolder.cpp;
/cvsroot/mozilla/mailnews/local/src/nsLocalMailFolder.cpp,v  <--  nsLocalMailFolder.cpp
new revision: 1.585; previous revision: 1.584