433759 - Empty description for hCalendar causes error in console

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: Add a check for value, and if it is undefined, set the value of description to ""

If description is empty in an hCalendar, the creation of the object that is contstructed to represent the HTML or string of the description throws an error because it doesn't test value first.

Comment 1

[Mike Kaply [:mkaply]]

Comment on attachment 320978 [details] [diff] [review]
Add a check for value, and if it is undefined, set the value of description to ""

Correctness fix for microformats.

Comment 2

[Mike Kaply [:mkaply]]

fixed in hg.

Comment 3

[Daniel Veditz [:dveditz]]

Comment on attachment 320978 [details] [diff] [review]
Add a check for value, and if it is undefined, set the value of description to ""

Approved for 1.9.0.4, a=dveditz for release-drivers

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 320978 [details] [diff] [review]
Add a check for value, and if it is undefined, set the value of description to ""

sorry, unapproving.

You'll need to appeal to the project leaders (mconnor,beltzner, etc) because these don't fit the narrow regression/security bug criteria we now use.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 320978 [details] [diff] [review]
Add a check for value, and if it is undefined, set the value of description to ""

In order to reduce risk and minimize overhead for stability releases, we are not accepting "nice to have" patches in stability releases.  As 3.1 is fast approaching, this should not unduly impact time to get these fixes to users.