433804 - buildPlatformImage() function outputs non working javascript because html quotes are not escapes

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

The buildPlatformImage() function on the Tips in product page does not take into account single quotes in the text put into the alt attribute of images, escaped quotes in the originating php variable should be converted to html entities because we are using it into javascript and the quotes are unvoluntarily ending the javascript document.write

<?=buildPlatformImage("/$lang/img/tignish/tips/beginner-01.jpg", 'Copie d\'écran du zoom', '365', '251', 'right')?>

Generates:

document.write('<img src="/fr/img/tignish/tips/beginner-01-mac.jpg" alt="Copie d'écran du zoom" class="right" />');

while it should generate:
document.write('<img src="/fr/img/tignish/tips/beginner-01-mac.jpg" alt="Copie d&#039;écran du zoom" class="right" />');

At first sight, in the function, the following line :
$alt = htmlspecialchars($alt, ENT_COMPAT, 'UTF-8');

should be :

$alt = htmlspecialchars($alt, ENT_QUOTES, 'UTF-8');

Comment 1

[Steven Garrity [:sgarrity]]

This should be fixed in r13340.

Pascal, please confirm.

Comment 2

[Wil Clouser [:clouserw]]

Thanks steven.