43383 - display problem with the colors panel in the preferences dialog

Status: VERIFIED WORKSFORME

(SeaMonkey :: Preferences, defect, P3)

Description

[Alec Wolman]

The attached screenshot shows small area of extraneous purple pixels to the
right of the color selection area, for both the text / background area and
for the link colors area.

Comment 1

[sairuh (rarely reading bugmail)]

aaah, yes. those purple (and green) outlines are to label widgets that haven't
been converted to the xul widgets... jrgm, blake d'you know offhand of an
existing bug for this particular issue? thx!

Comment 2

[John Morrison]

Um, nope (other than the general admonition eradicating this stuff from
the code). There is an html:div and a <titledbutton> that are the offenders 
here. Looks like a straightforward replacement (modulo checking that the 
colorpicker logic is not depending on those exact element types).

Comment 3

[Blake Ross]

yeah, I've been noticing this for awhile.  don't know of a bug on this 
offhand.  I assume there's a reason why this hasn't been fixed prior to this 
bug, but reassigning to myself and I'll take a look.

Comment 4

[Blake Ross]

Looks like it's not as straightforward as it seems. reassigning to ben for now 
in an effort to clean up my list, but I'm not through with this one yet <evil 
laughter>

(sorry, it's late, i'm tired)

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

yes, I didn't bother converting these widgets because I figured I'd create 
an XBL colour picker popup thing that I could drop in to each of these 
cases. It's just that I haven't done so yet ;) 

Comment 6

[sairuh (rarely reading bugmail)]

ben, speaking of better color pickers, have you seen
http://home.netscape.com/computing/webbuilding/studio/feature19981111-5.html ?

(also see bug 42894.)

Comment 7

[Chris Lyon]

I'm no longer seeing the purple border on 2001060504 on Win2K.

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

worksforme

Comment 9

[sairuh (rarely reading bugmail)]

mass verification of WorksForMe bugs: to find all bugspam pertaining to this,
set your search string to "IfItWorksForSlappyTheSquirrelThenItWFM".

if you think this particular bug is *still* an open issue, please make sure of
the following before reopening:

a. that it's still a problem with ***recent trunk builds*** on the all
appropriate platform[s]

b. provide clear steps to reproduce (unless a good test case is already in the
bug report), making sure it pertains to the original problem (avoid morphing as
much as possible :)