Closed Bug 433831 Opened 17 years ago Closed 17 years ago

narcissus - string and regexp literal terminate at wrong position

Categories

(Core :: JavaScript Engine, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: nanto, Unassigned)

Details

Attachments

(1 file)

Attached patch Patch rv1.0Splinter Review
A single-quoted string literal doesn't recognize escaped single quotes and a regular expression literal doesn't recognize slashes in a character class. js> eval("'\\''"); ' js> evaluate("'\\''"); jsparse.js:166: SyntaxError: unterminated string literal: jsparse.js:166: '\' jsparse.js:166: ^ js> eval("/[/]/"); /[/]/ js> evaluate("/[/]/"); jsparse.js:170: SyntaxError: unterminated character class
Attachment #321028 - Flags: review?(brendan)
Comment on attachment 321028 [details] [diff] [review] Patch rv1.0 Thanks! I will check this in promptly. /be
Attachment #321028 - Flags: review?(brendan) → review+
Fixed: js/narcissus/jsparse.js 1.28 Thanks again, /be
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: