Closed Bug 433855 Opened 13 years ago Closed 13 years ago

Crash [@ nsAbLDAPProcessReplicationData::Done]

Categories

(MailNews Core :: LDAP Integration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9

People

(Reporter: standard8, Assigned: standard8)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

Seen in the 3.0a1 crash-stats:

ID: af5f5c8a-21f3-11dd-8a1c-001cc4e2bf68
Frame  	Module  	Signature [Expand]  	Source
0 	thunderbird.exe 	nsAbLDAPProcessReplicationData::Done 	mozilla/mailnews/addrbook/src/nsAbLDAPReplicationData.cpp:526
1 	thunderbird.exe 	nsAbLDAPProcessReplicationData::Abort 	mozilla/mailnews/addrbook/src/nsAbLDAPReplicationData.cpp:193
2 	thunderbird.exe 	nsAbLDAPProcessReplicationData::OnLDAPMessage 	mozilla/mailnews/addrbook/src/nsAbLDAPReplicationData.cpp:145
3 	xpcom_core.dll 	NS_InvokeByIndex_P 	mozilla/xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:101
4 	xpcom_core.dll 	nsProxyObjectCallInfo::Run 	mozilla/xpcom/proxy/src/nsProxyEvent.cpp:181
5 	xpcom_core.dll 	nsThread::ProcessNextEvent 	mozilla/xpcom/threads/nsThread.cpp:510

The offending line:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/addrbook/src/nsAbLDAPReplicationData.cpp&rev=1.31&mark=526#526

I think this is due to the possibility of the user canceling the search and it being aborted/ending at the same time, whichever one, we can easily fix this.
Attached patch The fixSplinter Review
Protect against a null query, in case we enter the function twice.
Attachment #321054 - Flags: superreview?(bienvenu)
Attachment #321054 - Flags: review?(bienvenu)
Attachment #321054 - Flags: superreview?(bienvenu)
Attachment #321054 - Flags: superreview+
Attachment #321054 - Flags: review?(bienvenu)
Attachment #321054 - Flags: review+
Patch checked in. Fixed.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
Product: Core → MailNews Core
Crash Signature: [@ nsAbLDAPProcessReplicationData::Done]
You need to log in before you can comment on or make changes to this bug.