433883 - A flash object only appears on half the page

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Josh Tumath]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051406 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051406 Minefield/3.0pre

A flash applet by the BBC is made via CSS to appear covering the entire page. The following is ALL of the CSS on the page:

<style type="text/css">
<!--
body{
	height: 100%;
	width: 100%;
	margin: 0px;

-->
</style>

The applet only appears on the top half of the page. The bottom half is just a blank space.

Reproducible: Always



Expected Results:  
The hole page should be covered with the flash object.

Comment 1

[Mike Schroepfer]

Can you test this in Firefox 2 and the Firefox 3 nightlies to understand when this broke - unfortunately I cannot test the URL in the US (page says it cannot be viewed outside the UK)

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Confirmed as a regression between Fx2 and Fx3 RC1 build1 (testing on OS X Tiger). Trying to narrow that range now.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Screenshot on Fx3 RC1 build1

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

I see the same half-screen display with 3.0a1, a4, a5, b2 and b3 (the stuff I had on disk). Do you want to go digging in the pre-alpha1 nightlies ?

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

This regressed between the 2005-10-07 and 2005-10-08 nightlies (see http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2005/10/)

The checkin window is http://tinyurl.com/5ehaus - taking a stab at CC'ing the relevant developers.

Comment 6

[Dave Townsend [:mossop]]

This is a regression from bug 309118. Before that the object tag gets a vertical-align of baseline, after it defaults to top.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Any chance of attaching a testcase that shows the problem to this bug?  The site locks out IP addresses that are not in the UK, apparently, so I can't see what the page looks like...

Comment 8

[Dave Townsend [:mossop]]

Attachment: testcase, clock should be vertically centered

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So the problem is that we're applying the 'vertical-align: top' to the OBJECT, but what we're displaying is the EMBED inside it.  That that combination sticks out of the top of the page is a longstanding bug (bug 118501).

Comment 10

[Boris Zbarsky [:bzbarsky]]

Ah, so the issue is that the <object> is aligned, and so is the the <embed>, and they're aligned _differently_, right?  That is, removing the align attr on the embed, or setting it to "top" will give the correct behavior.

This is basically a bug in the page.  It used to work because we ignored the align="top" on the object altogether earlier in the 1.9 cycle, and used to work in 1.8 because we removed the <object> from the rendering tree completely there.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So I think the correct long-term fix (or at least part of it) is the pair of patches I put in bug 118501; I'm not sure what the right thing to do for 3.0.* is, though.

Comment 12

[Mike Schroepfer]

David/Bz you ok with taking this off the 1.9 blocker list then?

Comment 13

[Boris Zbarsky [:bzbarsky]]

I think I am, yes.

Comment 14

[Josh Tumath]

Umm. Shouldn't Firefox be able to fix this anyway? Quite a lot of websites might have this problem.

Comment 15

[Boris Zbarsky [:bzbarsky]]

> Shouldn't Firefox be able to fix this anyway? 

That's what bug 118501 is about.  We could back out the patch that triggered this on trunk, but that would break other sites, so...

> Quite a lot of websites might have this problem.

To be honest... this is the first report of this problem.  It's been around since October 2005 (two and a half years).  The fact is, to trigger it you need to have an embed inside an object, align them both, and align them _differently_.  That last part is really rare.

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

embed inside IE-specific-object is unfortunately the most common way of embedding plugins, though.

Comment 17

[Josh Tumath]

So is this bug a problem that the BBC should be worried about rather than a Gecko rendering issue?

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

...or one of the most common, anyway.

Comment 19

[Boris Zbarsky [:bzbarsky]]

David, it's the "align them both and align them differently" part that's rare, from what I've seen.

Josh, the BBC could fix it pretty easily by simply using align="top" on both nodes.  It's still a Gecko rendering issue, of course.

Comment 20

[Mike Schroepfer]

Given comment 13, comment 15, and comment 19 I'm taking this off the blocker list.  

Comment 21

[(mostly gone) XtC4UaLL [:xtc4uall]]

this is now FIXED by the fix for Bug 118501 testing the bbc site example and the attached testcase.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008071103