433884 - Invalid geos show up as empty geos in a vcard

Status: RESOLVED FIXED

(Toolkit Graveyard :: Microformats, defect)

Description

[Mike Kaply [:mkaply]]

Attachment: validate the microformat when we parse it and check for the error

If a vcard has a geo, but that geo is invalid, it should just simply not be there. Currently we insert an empty geo.

Note that this code was in place because there are cases like location in vevent where something can be a microformat or text, so just because something is an invalid microformat, doesn't mean we don't put anything there. We're no checking to see if the node is a microformat AND creation failed, and then it is empty. If it wasn't a microformat, the child node gets the text. The new test reflects this.

Comment 1

[Mike Kaply [:mkaply]]

fix checked in

Comment 2

[Mike Kaply [:mkaply]]

Comment on attachment 321073 [details] [diff] [review]
validate the microformat when we parse it and check for the error

microformats correctness

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 321073 [details] [diff] [review]
validate the microformat when we parse it and check for the error

In order to reduce risk and minimize overhead for stability releases, we are not accepting "nice to have" patches in stability releases.  As 3.1 is fast approaching, this should not unduly impact time to get these fixes to users.