Invalid geos show up as empty geos in a vcard

RESOLVED FIXED

Status

()

Toolkit
Microformats
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 321073 [details] [diff] [review]
validate the microformat when we parse it and check for the error

If a vcard has a geo, but that geo is invalid, it should just simply not be there. Currently we insert an empty geo.

Note that this code was in place because there are cases like location in vevent where something can be a microformat or text, so just because something is an invalid microformat, doesn't mean we don't put anything there. We're no checking to see if the node is a microformat AND creation failed, and then it is empty. If it wasn't a microformat, the child node gets the text. The new test reflects this.
(Assignee)

Updated

10 years ago
Attachment #321073 - Flags: review?(sayrer)

Updated

10 years ago
Attachment #321073 - Flags: review?(sayrer) → review+
(Assignee)

Comment 1

10 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 2

10 years ago
Comment on attachment 321073 [details] [diff] [review]
validate the microformat when we parse it and check for the error

microformats correctness
Attachment #321073 - Flags: approval1.9.0.3?

Updated

10 years ago
Attachment #321073 - Flags: approval1.9.0.4? → approval1.9.0.4-
Comment on attachment 321073 [details] [diff] [review]
validate the microformat when we parse it and check for the error

In order to reduce risk and minimize overhead for stability releases, we are not accepting "nice to have" patches in stability releases.  As 3.1 is fast approaching, this should not unduly impact time to get these fixes to users.
You need to log in before you can comment on or make changes to this bug.