433896 - The location bar and search box can appear too wide in Customize Toolbar

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051206 Minefield/3.0pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008051206 Minefield/3.0pre

Taking the location bar off the navigation bar results in Customize Toolbar showing controls incorrectly.

Please, see screenshots.

Reproducible: Always

Steps to Reproduce:
1. Take location bar off the navigation bar.
2. Customize toolbars.
3. See how controls are not properly shown (they overlap).

Comment 1

[Andrés Delfino]

Attachment: Customize Toolbar after removing the location bar from the navigation bar.

Comment 2

[Andrés Delfino]

Attachment: Customize Toolbar after removing leaving both navigation and bookmarks toolbar empty.

Comment 3

[Kai Liu]

I see this too.  But not on a clean profile.

Better STR:
* Start Firefox with a clean profile.
* Use the resizer to change the sizes of the location bar & search box.
* Restart Firefox.
* Go customize the toolbars and remove the location bar.

The problem is that when the width is changed, the saved width gets carried into the toolbar palette.

Comment 4

[Kai Liu]

Attachment: fix?

This fixes the problem for me; I didn't notice any undesirable side effects during testing, either.

Since Firefox 2 didn't allow the search box & location bar to be resized, this is a problem new to Firefox 3, so I guess this could be called a regression.  I think it'd nice to get this fixed for 3.0.1 (even if removing the location bar probably isn't something that people will be doing very often).

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/index.cgi/rev/17c672e325df

Comment 6

[Samuel Sidler (old account; do not CC)]

Any way we can get a test for this?

Comment 7

[Samuel Sidler (old account; do not CC)]

Comment on attachment 321143 [details] [diff] [review]
fix?

Pushing approval out to 1.9.0.3.

Comment 8

[Samuel Sidler (old account; do not CC)]

We're opting not to take this in a maintenance release.