434010 - Improve OpenID registration experience

Status: RESOLVED FIXED

(Webtools Graveyard :: Party Tool, defect, P3)

Description

[Alex Buchanan [:abuchanan]]

I tried registering with open ID on the stage site.  I noticed a couple broken things...

1) if the user doesn't have JS enabled, the openID textbox shows above the regular registration form, with another submit button.  it's kind of confusing in my opinion.

2) if the openID entered is invalid, the form redirects to the regular registration form, no error message

3) if JS is disabled, submitting an openID redirects to an invalid url.  looks like it appends the openID authenticate url to then end of the party tool base url, could be a  by-product of my i18n work, I'll look at this

4) with JS, I made it to myopenid.com, and clicked "allow forever", after i was redirected back to the stage site, I get an "openid_auth_failure"

Ryan any ideas?  How hard will this be to sort out? 

Side note, it would be great if the OpenID stuff submitted to it's own controller function, instead of sorting out both regular and openID auth in the same Users_controller::register() function, Ryan do you think this is possible?

Polvi and Ryan, I'm wondering if this is a feature we should be pushing after initial launch, as our schedule is growing shorter and shorter.  Ryan you are familiar with the system, is this something you want to fix up before Monday?

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

3 and 4 have been fixed by r13300 and r13302. We were running into a few redirection and signature validity issues by instructing the ID provider to return to a non-localized URL.

Morphing this to focus on the remaining two issues.

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

13898