Incorrect name for the Persian locale in SUMO

VERIFIED FIXED in 0.7.2

Status

--
minor
VERIFIED FIXED
11 years ago
9 years ago

People

(Reporter: Ehsan, Assigned: ecooper)

Tracking

unspecified
0.7.2

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: sumo_only, URL)

Attachments

(2 attachments)

(Reporter)

Description

11 years ago
The locale name for Persian (fa) in SUMO is currently فارسي.  This word which uses the unicode "U+064A ARABIC LETTER YEH" character.  This is incorrect, and the "U+06CC ARABIC LETTER FARSI YEH" character should be used instead.  The correct form of the word should be:

فارسی

I'm not sure how many places in tikiwiki language names are defined, but this should be fixed globally.
(Reporter)

Comment 1

11 years ago
See this URL for a sample of the incorrect word appearing:

<http://support.mozilla.com/tiki-listpages.php?maxRecords=15&lang=fa&categId=17>

Comment 2

11 years ago
I believe this is defined only in one place: http://svn.mozilla.org/projects/sumo/trunk/lang/langmapping.php

Can you directly modify that file and attach the modified one to this bug? I'm not sure whether Bugzilla does anything to encodings - if so, perhaps zipping it up will help?
(Reporter)

Comment 3

11 years ago
Created attachment 321362 [details] [diff] [review]
Patch

Here's a patch which corrects some additional problems as well:

1. Change "Farsi" to "Persian"
2. Change the occurrences of Arabic Keh and Yeh letters to their Persian counterparts.

The patch is big, but simple enough, I guess.
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #321362 - Flags: review?(nelson)
(Reporter)

Comment 4

11 years ago
Ping?

Comment 5

11 years ago
Jason, could you check this in?
(Reporter)

Comment 6

10 years ago
Ping...?

Comment 7

10 years ago
Taking so I remember.
Assignee: ehsan.akhgari → jason.barnabe
Status: ASSIGNED → NEW

Comment 8

10 years ago
Committed to trunk as r17720 with some extra modifications for new locales. If it looks good on support-stage, let me know and I'll apply it to production.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

10 years ago
Thanks!  The changes on <http://viewvc.svn.mozilla.org/vc?limit_changes=0&view=rev&revision=17720> look good, but I don't have a login on support-stage.mozilla.org so I can't really check it out there.
It's a universal username:password.
support:stage
(Reporter)

Comment 11

10 years ago
Thanks.

Am I being mistaken, or was this change not pushed to support-stage yet?  I couldn't see any change there...

Comment 12

10 years ago
Oh, I think I forgot about how stage pulls from the production branch. I'll get it in tonight.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 13

10 years ago
I pushed it in as r17783. The staging server says my cookies are disabled, so I'm not able to access the area where I can check.
(Reporter)

Comment 14

10 years ago
I get the same issue on support-stage, and judging from the languages in the drop-down box, the change has not yet been correctly made (it displays فارسي instead of فارسی)...

Comment 15

10 years ago
Ehsan, does this still look wrong?
(Reporter)

Comment 16

10 years ago
(In reply to comment #15)
> Ehsan, does this still look wrong?

Yes, both in support-stage and the live site.

Updated

10 years ago
Assignee: jason.barnabe → smirkingsisyphus
Target Milestone: --- → 0.7.2
(Assignee)

Comment 17

10 years ago
Created attachment 344813 [details] [diff] [review]
patch to update language map.

It looks like langmapping.php was never updated.
Attachment #344813 - Flags: review?(nelson)
(Reporter)

Comment 18

10 years ago
Comment on attachment 344813 [details] [diff] [review]
patch to update language map.

The Persian word in this patch looks fine.

Comment 19

10 years ago
Comment on attachment 344813 [details] [diff] [review]
patch to update language map.

committed to r19479/r19480
Attachment #344813 - Flags: review?(nelson) → review+

Updated

10 years ago
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED
(Reporter)

Comment 20

10 years ago
Verified on support-stage.  Thanks!
Status: RESOLVED → VERIFIED

Updated

10 years ago
Keywords: push-needed
Keywords: push-needed
(Reporter)

Updated

10 years ago
Attachment #321362 - Flags: review?(nelson)
Whiteboard: sumo_only
You need to log in before you can comment on or make changes to this bug.