434055 - python version check should happen in client.py

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Doug Turner (:dougt)]

some systems install python 2.3 and do not have 2.5 installed. Since 2.5 is required, we should do a simple test in client.py and notify the developer that a newer version is required.

Comment 1

[Doug Turner (:dougt)]

Attachment: adds a check for python 2.5

note that we had to put the test for the version in between the imports because I am not sure that OptionParser is available in older versions of python.

Comment 2

[[e-mail] (:bhearsum)]

FWIW:

14.3 optparse -- More powerful command line option parser
New in version 2.3.

Comment 3

[(not currently active) Ted Mielczarek]

Do we really require Python 2.5? I was pretty sure we'd been avoiding that dependency. What exactly requires it?

Comment 4

[Doug Turner (:dougt)]

@ben - cool; thanks.  We probably should continue to keep the test very high for the poor developer that somehow screwed up and has a 2.2 install.

Comment 5

[Ray Kiddy]

In response to comment # 3, see bug 427750, "Require python >= 2.5 to build Mozilla".

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 321274 [details] [diff] [review]
adds a check for python 2.5

AFAIK we don't require Python 2.5 yet, so if there are instances where we do, those are bugs.

Comment 7

[Doug Turner (:dougt)]

.py is not needed any longer.

Comment 8

[Benjamin Smedberg]

We still require python 2.3 for the build system (preprocessor.py and others).