Closed Bug 434068 Opened 13 years ago Closed 13 years ago

Mercurial client.mk does not provide CONFIG_GUESS

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: crowderbt, Assigned: crowderbt)

References

Details

Attachments

(1 file)

This seems to be the relevant delta (or part of it):

-CONFIG_GUESS_SCRIPT := $(wildcard $(TOPSRCDIR)/build/autoconf/config.guess)
-ifdef CONFIG_GUESS_SCRIPT
-  CONFIG_GUESS = $(shell $(CONFIG_GUESS_SCRIPT))
-else
-  _IS_FIRST_CHECKOUT := 1
-endif
Blocks: 433384
This happened as part of bsmedberg's removal of CVS checkout from client.mk:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/52123bb69106

I think it was just an oversight, and we should put it back. (Although we don't need the _IS_FIRST_CHECKOUT bits.)

crowder: want to submit a patch?
Assignee: nobody → crowder
Status: NEW → ASSIGNED
Attachment #321297 - Flags: review?(ted.mielczarek)
Comment on attachment 321297 [details] [diff] [review]
restore CONFIG_GUESS

Thanks, sorry about that.
Attachment #321297 - Flags: review?(ted.mielczarek) → review+
changeset:   15137:819a2c29e295
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.