434110 - imap subscribe UI doesn't handle folders with a leading hierarchy delimiter

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[David :Bienvenu]

From the news posting pointed to by the above URL:

My IMAP server has the following mailboxes:

/users/ams/INBOX
/archives/example

The INBOX, and any other mailboxes under /users/ams, are accessible as
unqualified names (i.e. relative names like "foo"). Correspondingly, it
sends a NAMESPACE response like this:

S: * NAMESPACE (("" "/")) (("/users/" "/")) (("/" "/"))

Now, I start Thunderbird and set up an account; connect to the server,
and go to the "subscribe" menu item. There I see "archives", with a "+"
next to it, which I click, to reveal "example". I check the box next to
it, and click on "Subscribe".

As you can see from the attached session logs[1], Thunderbird then tries
to subscribe to "archives/example" (note: no leading /), though it has
been given no reason (via LSUB/LIST responses) to believe that such a
mailbox exists.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

this seems to fix it the problem for me - it shouldn't affect news, which doesn't have newsgroup names that start with hierarchy delimiters, and it rarely happens for imap. I'm still testing that other things still work with these folders, but subscribe seems fine.

Comment 2

[David :Bienvenu]

Comment on attachment 321341 [details] [diff] [review]
proposed fix

Maybe Neil has time for this review - this only affects imap (newsgroup names don't start with a '.')

Comment 3

[[e-mail]]

Comment on attachment 321341 [details] [diff] [review]
proposed fix

I take it we never list "/" itself do we?

The code seems somewhat unclear but I couldn't think of a better way.

Comment 4

[David :Bienvenu]

No, listing "/" by itself would be meaningless.